Re: [PATCH] gdb: ensure bp_location::section is set correct to avoid an assert

[Andrew Burgess <aburgess@redhat.com>]

Simon Marchi <simark@simark.ca> writes:

> On 2026-02-02 03:49, Rohr, Stephan wrote:
>> Hi all,
>> 
>> I came across the same issue when debugging a remote inferior that is compiled w/o debug symbols and a
>> breakpoint is inserted based on the function name that is called in the inferior. 
>> 
>> Our test started to regress with the introduction of patch
>> "gdb: ensure bp_location::section is set correct to avoid an assert".  As mentioned in the patch above,
>> GDB uses the default gdbarch to insert the breakpoint if the section is NULL.  This causes issues later. 
>> 
>> I applied the patch; our breakpoint insertion issue is fixed with this patch.  I reviewed the patch, it is
>> reasonable to me.  Only thing I wonder is the usage of 'find_pc_ovelay'; this always returns NULL if
>> overlay debugging is not used? But I guess that's fixed by using 'find_pc_section' in this case.
>> 
>> Thanks for working on this, Andrew!
>
> I had forgotten about this patch, I think we solved the ROCm issue at
> another level, with:
>
> [PATCH 0/4] make it the responsibility of a symtab_and_line's creator to set its section
> https://inbox.sourceware.org/gdb-patches/20251024162929.352719-1-sdarche@efficios.com/
>
> Andrew, could you send an updated version of your patch?  It doesn't
> apply anymore, and I think it would deserve not being buried in that
> other patch's big thread.

I'll get this updated and send a new version today.

Thanks,
Andrew