From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sSiQGfUzg2k/+ScAWB0awg (envelope-from ) for ; Wed, 04 Feb 2026 06:56:37 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=i3gUsoM6; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 633911E0BA; Wed, 04 Feb 2026 06:56:37 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED,RDNS_NONE autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (unknown [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B647C1E08D for ; Wed, 04 Feb 2026 06:56:36 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 4C1014BA2E17 for ; Wed, 4 Feb 2026 11:56:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4C1014BA2E17 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=i3gUsoM6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id CCA654BA2E16 for ; Wed, 4 Feb 2026 11:55:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CCA654BA2E16 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CCA654BA2E16 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770206135; cv=none; b=sfWMr8nHoaILqjkbVmqrwu8Jn2Ay8tGYex/PsRlnQjhIwEyB29KdqbVU1MD/D0a8RlbOOj/ys0+pWhcmIkZUHB1NPj+iN+H0i9ugDIm7Cr96I8l2x+Eqlhvv10ORGB/boxFNWlnaVBiobZGKct5bRmx3Mbr5fMLGC6ZncQx6XwM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770206135; c=relaxed/simple; bh=qTdWx4WpwTq9TiQuGNsjk5oIYAB85cNytizbKqJt9o8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=KMX5/ED8JDPgGL4QrE39os2SvKMDB2PwQt03Wq5QNy09JKgRqUffDudnyeWsnJhk4XoNpQKxoxthYcEfPTyxl2eMgMmvj/5tvYUaAvofiUbAn53OY84aLCBUqM5appXQvWEIpXQuPpezpAJTZJxQpa/9vDp6XD2GVHudRT2lifI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CCA654BA2E16 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770206135; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JrftFEi/kTEEmoQ4UP+7dGfLRxi6WyIL3Rk1K312i2A=; b=i3gUsoM6qAZYZjRoaJzyQ4snpGYpICUeDNsj5BKZREpDtRjLroZ6MvYmv2kTcLS1k7yJHQ 9LNQsHylFnK7nyjmVqEx8QQLaBwt0PMf55v8s6ovxs4N5l7sZGn3hzwoiiaEBpoQzcoO80 XZ8au2SaiCE8uJgALf2YVHaxZ9MPnsI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-297-5rywkeg_Os2Hc-d1NSRVtQ-1; Wed, 04 Feb 2026 06:55:34 -0500 X-MC-Unique: 5rywkeg_Os2Hc-d1NSRVtQ-1 X-Mimecast-MFC-AGG-ID: 5rywkeg_Os2Hc-d1NSRVtQ_1770206133 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4806e7c4220so7897745e9.2 for ; Wed, 04 Feb 2026 03:55:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770206132; x=1770810932; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JrftFEi/kTEEmoQ4UP+7dGfLRxi6WyIL3Rk1K312i2A=; b=Q6JnyMPwbfqJTKjE78iJp9GWvW2dUUPvUsHe3XZKPQHVtd3u9AMFRhxokfcgJSjiDD t/Qetfdw5GLHB7nI5cTMQTHpD9c2/ehiT0EWqxQ6xpgi8fWz6THN0rYme8K8/SFovIaK KWkF8qsxLFHIBGtJPMTOJW46bHROwvBJtWO2UbCZbhqFZ6/D3IEiESpOerlla6zuIsb5 yW4O6RHiWjtH+IEa2JofwFltC2zzL/8/4jMIex/+ql011M0Xkl+8jThTMCnKi7J1mgHJ UyWDt85WZDW83v9+eRuRftOtAdfdQws7ERMP+TiB8Kf0I+UEzM2DtOE/AoKmmId3ocFT hKPA== X-Gm-Message-State: AOJu0YzoMSNLrgt7SmKeI8zO5o91wRgD5h21BtxEdA1tNC5zBaJPALhY mf/enQfg16mlbC3dU9JyYvWq7jrXWi0onHVoANA20faF+WcyCLPn8fDyJiSwLx3IXndLjIROdXs 6u0gh7KftaZ8lNo/4TqpXCmkYMjm1+tIMPT7+x01KiiK+CYFwSJNRtmihOCyBn2QjsnewIm8= X-Gm-Gg: AZuq6aJ27odGk2wlZTC2NCkvKwHfm/1L6ASlsa2kk53HQktHHD2FXJqt694rly1x3FD 0PiY4XT3eczBYTSnLoTKrT4ADYqSduH2vi2E1AOEEv7rXxdlO0+2HCiiqPvbl3cQMg44f1L3lIB 79Nm8kZypt/eKfLIJ+th7kOwLzL9ralPgd1jktSyOSwvefj93rF8tEW4QZiVJsiU5IG/iF6AZvJ X2aIQ7EKRvCyKEgb2TzNJOV7jtcHdRnbIqBIYxWWJENIqqbkYrJ0qhJcGK/ry+HPrbeq9TecEc2 OLXiiXqEpcF3yl1sgXPQ56chyJod+yB19+VUiYqoz3qEbmu7XzhQicKdMGL5G8MjaO8rv6Eycfq 3blO4 X-Received: by 2002:a05:600c:444b:b0:47d:92bb:2723 with SMTP id 5b1f17b1804b1-4830e9262f7mr42096665e9.3.1770206132529; Wed, 04 Feb 2026 03:55:32 -0800 (PST) X-Received: by 2002:a05:600c:444b:b0:47d:92bb:2723 with SMTP id 5b1f17b1804b1-4830e9262f7mr42096385e9.3.1770206132135; Wed, 04 Feb 2026 03:55:32 -0800 (PST) Received: from localhost ([31.111.84.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4830fe69e9fsm23002345e9.6.2026.02.04.03.55.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 03:55:31 -0800 (PST) From: Andrew Burgess To: Simon Marchi , "Rohr, Stephan" , =?utf-8?Q?S=C3=A9bastien?= Darche Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH] gdb: ensure bp_location::section is set correct to avoid an assert In-Reply-To: References: <7febb0c1-7bbd-45d5-8ebe-91c34bb4a6ce@efficios.com> <87tt0qe7qf.fsf@redhat.com> <87ldm2dxcl.fsf@redhat.com> <6c31b667-db2d-453e-9597-9fe011c4766e@efficios.com> <87jz186xhv.fsf@redhat.com> Date: Wed, 04 Feb 2026 11:55:31 +0000 Message-ID: <87qzr0en9o.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TmhPKSO-FaNFRoRgdS-kexVaWWyRjHjNrXZCn2wbU1Y_1770206133 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon Marchi writes: > On 2026-02-02 03:49, Rohr, Stephan wrote: >> Hi all, >> >> I came across the same issue when debugging a remote inferior that is compiled w/o debug symbols and a >> breakpoint is inserted based on the function name that is called in the inferior. >> >> Our test started to regress with the introduction of patch >> "gdb: ensure bp_location::section is set correct to avoid an assert". As mentioned in the patch above, >> GDB uses the default gdbarch to insert the breakpoint if the section is NULL. This causes issues later. >> >> I applied the patch; our breakpoint insertion issue is fixed with this patch. I reviewed the patch, it is >> reasonable to me. Only thing I wonder is the usage of 'find_pc_ovelay'; this always returns NULL if >> overlay debugging is not used? But I guess that's fixed by using 'find_pc_section' in this case. >> >> Thanks for working on this, Andrew! > > I had forgotten about this patch, I think we solved the ROCm issue at > another level, with: > > [PATCH 0/4] make it the responsibility of a symtab_and_line's creator to set its section > https://inbox.sourceware.org/gdb-patches/20251024162929.352719-1-sdarche@efficios.com/ > > Andrew, could you send an updated version of your patch? It doesn't > apply anymore, and I think it would deserve not being buried in that > other patch's big thread. I'll get this updated and send a new version today. Thanks, Andrew