From: Thomas Schwinge <thomas@codesourcery.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [testuite patch] Fix cross-arch .S testsuite files compatibility
Date: Wed, 21 Mar 2012 11:37:00 -0000 [thread overview]
Message-ID: <87pqc6fanj.fsf@schwinge.name> (raw)
In-Reply-To: <20120316085158.GA26740@host2.jankratochvil.net>
[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]
Hi!
On Fri, 16 Mar 2012 09:51:58 +0100, Jan Kratochvil <jan.kratochvil@redhat.com> wrote:
> On Thu, 15 Mar 2012 10:32:06 +0100, Thomas Schwinge wrote:
> > On Thu, 15 Mar 2012 10:06:02 +0100, Jan Kratochvil <jan.kratochvil@redhat.com> wrote:
> > > On Thu, 15 Mar 2012 09:57:11 +0100, Thomas Schwinge wrote:
> > > > Can there be other semantic differences between the two?
> > >
> > > It is a good question and I am not aware of any such differences.
> >
> > Hmm, I just had a quick look, and found that, for example, tc-arm.c has
> > this:
> >
> > #ifdef OBJ_ELF
> > { "word", s_arm_elf_cons, 4 },
> > { "long", s_arm_elf_cons, 4 },
> >
> > ... and obj-elf.c:
> >
> > {"4byte", cons, 4},
> >
> > Compared to cons, s_arm_elf_cons does quite a lot of things, for example
> > handle mapping symbols (which cons doesn't do, I think?).
>
> It does not seem to be needed for these testcases, they still PASS on:
> armv7l-unknown-linux-gnueabihf
> (I did not verify if they still FAIL->PASS by their specific fixes.)
I still have some reservations about this patch, but I won't hold it up
having now now tested that it doesn't change the test results for
sh-linux-gnu cross-testing -- SH also differentiates between using
sh_elf_cons for .long/.int/etc. vs. s_uacons for .2byte/.4byte/.8byte.
Grüße,
Thomas
[-- Attachment #2: Type: application/pgp-signature, Size: 489 bytes --]
next prev parent reply other threads:[~2012-03-21 11:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 20:27 Jan Kratochvil
2012-03-15 8:57 ` Thomas Schwinge
2012-03-15 9:06 ` Jan Kratochvil
2012-03-15 9:32 ` Thomas Schwinge
2012-03-16 8:52 ` Jan Kratochvil
2012-03-21 11:37 ` Thomas Schwinge [this message]
2012-03-19 14:04 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqc6fanj.fsf@schwinge.name \
--to=thomas@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox