Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [testuite patch] Fix cross-arch .S testsuite files compatibility
Date: Thu, 15 Mar 2012 09:06:00 -0000	[thread overview]
Message-ID: <20120315090602.GA7079@host2.jankratochvil.net> (raw)
In-Reply-To: <87aa3ikzrs.fsf@schwinge.name>

On Thu, 15 Mar 2012 09:57:11 +0100, Thomas Schwinge wrote:
> In my patch I had explicitly taken care to replace .long with .4byte only
> in .debug_* sections (and only in files that are not x86-specific, as it
> doesn't matter for those).  You're now proposing such changes, too:

I checked specifically the "v" case where .debug_info already expects it takes
_4_ bytes:
        .byte   0x4     /* DW_AT_byte_size */

It is true I did not check other cases but:


> I just wanted to check whether we can be sure that .4byte always conveys
> the same meaning as .long did in such cases?

as these testfiles were created on x86* .long is compiled there as .4byte.
This means that any such occurence of .long can be replaced by .4byte.


> Can there be other semantic differences between the two?

It is a good question and I am not aware of any such differences.


> (And no, I don't think you could reasonably encode ``don't allow .long --
> but only in .debug_* sections'' in the ARI system...)  :-)

Fortunately we do not need full freedoms for the testfiles, we may restrict
them arbitrarily as long as one can write the needed testfiles afterwards.

Some of such restrictions would affecth gdb.arch/gdb.disasm testfiles so
I rather excluded them from the ARI verifications.  gdb.arch/gdb.disasm
testfiles are not made as multi-arch, therefore these arch-compatibility
issues should not affect them.


Thanks,
Jan


  reply	other threads:[~2012-03-15  9:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-14 20:27 Jan Kratochvil
2012-03-15  8:57 ` Thomas Schwinge
2012-03-15  9:06   ` Jan Kratochvil [this message]
2012-03-15  9:32     ` Thomas Schwinge
2012-03-16  8:52       ` Jan Kratochvil
2012-03-21 11:37         ` Thomas Schwinge
2012-03-19 14:04 ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120315090602.GA7079@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=thomas@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox