From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix DW_AT_lower_bound DWARF-4+ defaults
Date: Thu, 26 Apr 2012 16:09:00 -0000 [thread overview]
Message-ID: <87pqau8qan.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20120426150708.GA31687@host2.jankratochvil.net> (Jan Kratochvil's message of "Thu, 26 Apr 2012 17:07:08 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> + case language_d:
Jan> + case language_java:
Jan> + case language_objc:
Jan> + if (cu->header.version >= 4)
Jan> + low = 0;
Jan> + break;
I looked at the DWARF 3 spec and it says:
If the lower bound value is missing, the value is assumed to be a
language-dependent default constant. The default lower bound value for C
or C++ is 0. For Fortran, it is 1.
So it seems wrong to complain here; at least for Java and ObjC, where
there is only a single sensible default. I can't speak for the other
languages, but even there I think the DWARF text mentioning specific
defaults is informative, not exhaustive, and we should just pick a
reasonable default and not complain.
Tom
next prev parent reply other threads:[~2012-04-26 16:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 15:08 Jan Kratochvil
2012-04-26 16:09 ` Tom Tromey [this message]
2012-04-26 15:39 ` Jan Kratochvil
2012-04-26 15:55 ` Tom Tromey
2012-04-26 16:16 ` Jan Kratochvil
2012-04-26 20:35 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqau8qan.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox