From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19608 invoked by alias); 26 Apr 2012 16:06:35 -0000 Received: (qmail 19590 invoked by uid 22791); 26 Apr 2012 16:06:31 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Apr 2012 16:06:17 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3QG6GTj022558 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 26 Apr 2012 12:06:17 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3QFTaf2021467 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 26 Apr 2012 11:29:36 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix DW_AT_lower_bound DWARF-4+ defaults References: <20120426150708.GA31687@host2.jankratochvil.net> Date: Thu, 26 Apr 2012 16:09:00 -0000 In-Reply-To: <20120426150708.GA31687@host2.jankratochvil.net> (Jan Kratochvil's message of "Thu, 26 Apr 2012 17:07:08 +0200") Message-ID: <87pqau8qan.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00929.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> + case language_d: Jan> + case language_java: Jan> + case language_objc: Jan> + if (cu->header.version >= 4) Jan> + low = 0; Jan> + break; I looked at the DWARF 3 spec and it says: If the lower bound value is missing, the value is assumed to be a language-dependent default constant. The default lower bound value for C or C++ is 0. For Fortran, it is 1. So it seems wrong to complain here; at least for Java and ObjC, where there is only a single sensible default. I can't speak for the other languages, but even there I think the DWARF text mentioning specific defaults is informative, not exhaustive, and we should just pick a reasonable default and not complain. Tom