From: Tom Tromey <tromey@redhat.com>
To: Sanimir Agovic <sanimir.agovic@intel.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] cleanup: constify "struct attribute" function parameter
Date: Fri, 26 Jul 2013 14:44:00 -0000 [thread overview]
Message-ID: <87ppu5tm7u.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1374824313-27525-1-git-send-email-sanimir.agovic@intel.com> (Sanimir Agovic's message of "Fri, 26 Jul 2013 09:38:33 +0200")
>>>>> "Sanimir" == Sanimir Agovic <sanimir.agovic@intel.com> writes:
Sanimir> This is a follow up on [1] and constifies the remaining arguments. Main
Sanimir> motivation is to document which functions modifiy its struct attribute
Sanimir> parameter.
Sanimir> 2013-07-25 Sanimir Agovic <sanimir.agovic@intel.com>
Sanimir> * dwarf2read.c (dwarf2_get_ref_die_offset): Constify struct
Sanimir> attribute parameter.
Sanimir> (dwarf2_const_value_data): Constify struct attribute parameter.
Sanimir> (dwarf2_const_value): Constify struct attribute parameter.
Sanimir> (dwarf2_const_value_attr): Constify struct attribute parameter.
Sanimir> (lookup_die_type): Constify struct attribute parameter.
Sanimir> (dwarf2_get_attr_constant_value): Constify struct attribute parameter.
Sanimir> (follow_die_ref_or_sig): Constify struct attribute parameter.
Sanimir> (follow_die_ref): Constify struct attribute parameter.
Sanimir> (follow_die_sig): Constify struct attribute parameter.
Sanimir> (get_DW_AT_signature_type): Constify struct attribute parameter.
Sanimir> (get_type_unit_group): Constify struct attribute parameter.
Sanimir> (fill_in_loclist_baton): Constify struct attribute parameter.
Sanimir> (dwarf2_symbol_mark_computed): Constify struct attribute parameter.
Sanimir> (type_unit_group): Constify struct attribute parameter.
Thanks, this is ok.
Tom
prev parent reply other threads:[~2013-07-26 14:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 7:38 Sanimir Agovic
2013-07-26 14:44 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppu5tm7u.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sanimir.agovic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox