From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31840 invoked by alias); 26 Jul 2013 14:44:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31831 invoked by uid 89); 26 Jul 2013 14:44:31 -0000 X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 26 Jul 2013 14:44:31 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6QEiNT9003619 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 26 Jul 2013 10:44:23 -0400 Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r6QEiLAj019233 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 26 Jul 2013 10:44:22 -0400 From: Tom Tromey To: Sanimir Agovic Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] cleanup: constify "struct attribute" function parameter References: <1374824313-27525-1-git-send-email-sanimir.agovic@intel.com> Date: Fri, 26 Jul 2013 14:44:00 -0000 In-Reply-To: <1374824313-27525-1-git-send-email-sanimir.agovic@intel.com> (Sanimir Agovic's message of "Fri, 26 Jul 2013 09:38:33 +0200") Message-ID: <87ppu5tm7u.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-07/txt/msg00638.txt.bz2 >>>>> "Sanimir" == Sanimir Agovic writes: Sanimir> This is a follow up on [1] and constifies the remaining arguments. Main Sanimir> motivation is to document which functions modifiy its struct attribute Sanimir> parameter. Sanimir> 2013-07-25 Sanimir Agovic Sanimir> * dwarf2read.c (dwarf2_get_ref_die_offset): Constify struct Sanimir> attribute parameter. Sanimir> (dwarf2_const_value_data): Constify struct attribute parameter. Sanimir> (dwarf2_const_value): Constify struct attribute parameter. Sanimir> (dwarf2_const_value_attr): Constify struct attribute parameter. Sanimir> (lookup_die_type): Constify struct attribute parameter. Sanimir> (dwarf2_get_attr_constant_value): Constify struct attribute parameter. Sanimir> (follow_die_ref_or_sig): Constify struct attribute parameter. Sanimir> (follow_die_ref): Constify struct attribute parameter. Sanimir> (follow_die_sig): Constify struct attribute parameter. Sanimir> (get_DW_AT_signature_type): Constify struct attribute parameter. Sanimir> (get_type_unit_group): Constify struct attribute parameter. Sanimir> (fill_in_loclist_baton): Constify struct attribute parameter. Sanimir> (dwarf2_symbol_mark_computed): Constify struct attribute parameter. Sanimir> (type_unit_group): Constify struct attribute parameter. Thanks, this is ok. Tom