From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] [python] Fix Python 3 build and testsuite issues
Date: Mon, 19 Aug 2013 18:34:00 -0000 [thread overview]
Message-ID: <87ppt9jzrl.fsf@fleche.redhat.com> (raw)
In-Reply-To: <52124B8D.6010609@redhat.com> (Phil Muldoon's message of "Mon, 19 Aug 2013 17:45:01 +0100")
>> sorted_list = list(_sort_list())
Phil> I avoided this because I did not want to convert an iterable to a list
Phil> (the new dict.keys/values/items returns a lightweight iterator instead
Phil> of a list.) My thoughts were that creating an imap or map like object
Phil> would be cheaper than creating a list from a lightweight iterator.
Perhaps it's a wash.
But the old code was also simpler to understand.
Phil> You mentioned
Phil> it applies elsewhere in the patchset? The only similar path is for the
Phil> filename, but that always creates a newly allocated string from
Phil> python_string_to_host_string. There is no other
Phil> newly-allocated/referenced pointer split in the code path in this
Phil> patch?
Yeah, I misread the filename handling hunk.
Sorry about that.
Tom
next prev parent reply other threads:[~2013-08-19 18:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 14:50 Phil Muldoon
2013-08-19 16:19 ` Tom Tromey
2013-08-19 16:45 ` Phil Muldoon
2013-08-19 18:34 ` Tom Tromey [this message]
2013-08-20 19:43 ` Phil Muldoon
2013-08-20 19:59 ` Tom Tromey
2013-08-20 20:32 ` Phil Muldoon
2013-08-21 14:29 ` Phil Muldoon
2013-08-21 14:59 ` Tom Tromey
2013-08-21 15:37 ` Paul_Koning
2013-08-21 15:42 ` Tom Tromey
2013-08-21 14:56 ` Tom Tromey
2013-08-22 10:46 ` Phil Muldoon
2013-08-27 15:41 ` Tom Tromey
2013-08-29 10:08 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppt9jzrl.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox