From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26211 invoked by alias); 19 Aug 2013 18:34:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26174 invoked by uid 89); 19 Aug 2013 18:34:26 -0000 X-Spam-SWARE-Status: No, score=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 19 Aug 2013 18:34:25 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7JIYOIG015138 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 19 Aug 2013 14:34:24 -0400 Received: from barimba (ovpn-113-142.phx2.redhat.com [10.3.113.142]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r7JIYMr3022855 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 19 Aug 2013 14:34:23 -0400 From: Tom Tromey To: Phil Muldoon Cc: "gdb-patches\@sourceware.org" Subject: Re: [patch] [python] Fix Python 3 build and testsuite issues References: <521230C8.2040803@redhat.com> <878uzxlkl1.fsf@fleche.redhat.com> <52124B8D.6010609@redhat.com> Date: Mon, 19 Aug 2013 18:34:00 -0000 In-Reply-To: <52124B8D.6010609@redhat.com> (Phil Muldoon's message of "Mon, 19 Aug 2013 17:45:01 +0100") Message-ID: <87ppt9jzrl.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-08/txt/msg00520.txt.bz2 >> sorted_list = list(_sort_list()) Phil> I avoided this because I did not want to convert an iterable to a list Phil> (the new dict.keys/values/items returns a lightweight iterator instead Phil> of a list.) My thoughts were that creating an imap or map like object Phil> would be cheaper than creating a list from a lightweight iterator. Perhaps it's a wash. But the old code was also simpler to understand. Phil> You mentioned Phil> it applies elsewhere in the patchset? The only similar path is for the Phil> filename, but that always creates a newly allocated string from Phil> python_string_to_host_string. There is no other Phil> newly-allocated/referenced pointer split in the code path in this Phil> patch? Yeah, I misread the filename handling hunk. Sorry about that. Tom