From: ludo@gnu.org (Ludovic Courtès)
To: Doug Evans <xdje42@gmail.com>
Cc: eliz@gnu.org, gdb-patches@sourceware.org
Subject: Re: [PATCH, doc RFA] Split create-breakpoint! into make-breakpoint, register-breakpoint!
Date: Wed, 04 Jun 2014 08:30:00 -0000 [thread overview]
Message-ID: <87ppipf55t.fsf@gnu.org> (raw)
In-Reply-To: <m3egz5cm1v.fsf@sspiff.org> (Doug Evans's message of "Tue, 03 Jun 2014 21:53:48 -0700")
Doug Evans <xdje42@gmail.com> skribis:
> In keeping with the splitting of object creation and registration into
> two separate pieces, this does the same for breakpoints.
> "Consistency Is Good".
That makes sense.
> There hasn't been an FSF release of gdb+guile yet so I think it's ok
> to remove create-breakpoint! here.
Yup.
> 2014-06-03 Doug Evans <xdje42@gmail.com>
>
> * guile/scm-breakpoint.c (struct gdbscm_breakpoint_object): New members
> is_scheme_bkpt, spec.
> (bpscm_make_breakpoint_smob): Initialize new members.
> (gdbscm_create_breakpoint_x): Split into two ...
> (gdbscm_make_breakpoint, gdbscm_register_breakpoint_x): New functions.
> (bpscm_breakpoint_deleted): Reset breakpoint number and stop function.
> (scheme_function breakpoint_functions): Update.
>
> testsuite/
> * gdb.guile/scm-breakpoint.exp: Update.
> Add tests for breakpoint registration.
>
> doc/
> * guile.texi (Breakpoints In Guile): Update.
LGTM.
Ludo’.
next prev parent reply other threads:[~2014-06-04 8:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 4:54 Doug Evans
2014-06-04 7:05 ` Eli Zaretskii
2014-06-04 8:29 ` Ludovic Courtès
2014-06-04 9:27 ` Eli Zaretskii
2014-06-04 13:47 ` Ludovic Courtès
2014-06-04 8:30 ` Ludovic Courtès [this message]
2014-06-05 2:58 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppipf55t.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox