From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24024 invoked by alias); 4 Jun 2014 08:30:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24008 invoked by uid 89); 4 Jun 2014 08:30:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: hera.aquilenet.fr Received: from hera.aquilenet.fr (HELO hera.aquilenet.fr) (141.255.128.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Jun 2014 08:30:25 +0000 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id CC7EA2AEE; Wed, 4 Jun 2014 10:30:23 +0200 (CEST) Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SptPTSrvY8xt; Wed, 4 Jun 2014 10:30:23 +0200 (CEST) Received: from pluto (reverse-83.fdn.fr [80.67.176.83]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 5E1902850; Wed, 4 Jun 2014 10:30:23 +0200 (CEST) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Doug Evans Cc: eliz@gnu.org, gdb-patches@sourceware.org Subject: Re: [PATCH, doc RFA] Split create-breakpoint! into make-breakpoint, register-breakpoint! References: X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 16 Prairial an 222 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu Date: Wed, 04 Jun 2014 08:30:00 -0000 In-Reply-To: (Doug Evans's message of "Tue, 03 Jun 2014 21:53:48 -0700") Message-ID: <87ppipf55t.fsf@gnu.org> User-Agent: Gnus/5.130009 (Ma Gnus v0.9) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2014-06/txt/msg00138.txt.bz2 Doug Evans skribis: > In keeping with the splitting of object creation and registration into > two separate pieces, this does the same for breakpoints. > "Consistency Is Good". That makes sense. > There hasn't been an FSF release of gdb+guile yet so I think it's ok > to remove create-breakpoint! here. Yup. > 2014-06-03 Doug Evans > > * guile/scm-breakpoint.c (struct gdbscm_breakpoint_object): New members > is_scheme_bkpt, spec. > (bpscm_make_breakpoint_smob): Initialize new members. > (gdbscm_create_breakpoint_x): Split into two ... > (gdbscm_make_breakpoint, gdbscm_register_breakpoint_x): New functions. > (bpscm_breakpoint_deleted): Reset breakpoint number and stop function. > (scheme_function breakpoint_functions): Update. > > testsuite/ > * gdb.guile/scm-breakpoint.exp: Update. > Add tests for breakpoint registration. > > doc/ > * guile.texi (Breakpoints In Guile): Update. LGTM. Ludo=E2=80=99.