From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/4] target_stack -> current_top_target() throughout
Date: Tue, 29 May 2018 03:13:00 -0000 [thread overview]
Message-ID: <87po1fxw2k.fsf@tromey.com> (raw)
In-Reply-To: <20180528161041.32497-2-palves@redhat.com> (Pedro Alves's message of "Mon, 28 May 2018 17:10:38 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
I didn't really read this patch, since after a few glances it looked
mechanical. But I did see a typo in the commit message
Pedro> Thus this commit renames target_target to current_top_target and
I think target_target -> target_stack here.
Tom
next prev parent reply other threads:[~2018-05-28 22:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 16:10 [PATCH 0/4] Change target stack representation Pedro Alves
2018-05-28 16:10 ` [PATCH 1/4] target_stack -> current_top_target() throughout Pedro Alves
2018-05-29 3:13 ` Tom Tromey [this message]
2018-05-28 16:19 ` [PATCH 2/4] target_ops::beneath -> target_ops::beneath() Pedro Alves
2018-05-28 17:39 ` [PATCH 3/4] Eliminate find_target_beneath Pedro Alves
2018-05-28 17:47 ` [PATCH 4/4] Introduce class target_stack Pedro Alves
2018-05-29 11:34 ` Tom Tromey
2018-05-29 14:59 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87po1fxw2k.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox