From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71471 invoked by alias); 28 May 2018 22:19:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71437 invoked by uid 89); 28 May 2018 22:19:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.222) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 28 May 2018 22:19:18 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 8B67F4B306B for ; Mon, 28 May 2018 17:19:17 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id NQU1fIitNBcCXNQU1fBiWy; Mon, 28 May 2018 17:19:17 -0500 X-Authority-Reason: nr=8 Received: from 174-29-44-154.hlrn.qwest.net ([174.29.44.154]:47930 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fNQU1-001MQv-9f; Mon, 28 May 2018 17:19:17 -0500 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] target_stack -> current_top_target() throughout References: <20180528161041.32497-1-palves@redhat.com> <20180528161041.32497-2-palves@redhat.com> Date: Tue, 29 May 2018 03:13:00 -0000 In-Reply-To: <20180528161041.32497-2-palves@redhat.com> (Pedro Alves's message of "Mon, 28 May 2018 17:10:38 +0100") Message-ID: <87po1fxw2k.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fNQU1-001MQv-9f X-Source-Sender: 174-29-44-154.hlrn.qwest.net (bapiya) [174.29.44.154]:47930 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-05/txt/msg00749.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: I didn't really read this patch, since after a few glances it looked mechanical. But I did see a typo in the commit message Pedro> Thus this commit renames target_target to current_top_target and I think target_target -> target_stack here. Tom