From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/4] Change thread_to_thread_object to return a new reference
Date: Sun, 16 Sep 2018 15:35:00 -0000 [thread overview]
Message-ID: <87pnxdo3p5.fsf@tromey.com> (raw)
In-Reply-To: <875zz5pmg8.fsf@tromey.com> (Tom Tromey's message of "Sun, 16 Sep 2018 08:05:11 -0600")
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
Tom> I think it is best to have a single style - returning NULL should also
Tom> set the Python exception.
Maybe the gdbpy_ref (1-argument) constructor and release methods could
assert that the Python exception is set if the underlying pointer is
NULL. That would not get full checking but maybe it would catch some
problems. And maybe we should simply use gdbpy_ref in many more places
in the Python layer -- ideally, reserve raw pointers solely for
parameters which are borrowed references.
Tom
next prev parent reply other threads:[~2018-09-16 15:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 5:30 [PATCH 0/4] Disallow the return of borrowed references Tom Tromey
2018-09-13 5:30 ` [PATCH 1/4] Change pspace_to_pspace_object to return a new reference Tom Tromey
2018-09-16 0:57 ` Simon Marchi
2018-09-16 12:59 ` Tom Tromey
2018-09-16 1:19 ` Simon Marchi
2018-09-16 1:58 ` Simon Marchi
2018-09-16 13:01 ` Tom Tromey
2018-09-13 5:30 ` [PATCH 3/4] Change thread_to_thread_object " Tom Tromey
2018-09-16 2:11 ` Simon Marchi
2018-09-16 13:32 ` Tom Tromey
2018-09-16 14:05 ` Tom Tromey
2018-09-16 15:35 ` Tom Tromey [this message]
2018-09-17 0:52 ` Simon Marchi
2018-09-17 5:31 ` Tom Tromey
2018-09-13 5:30 ` [PATCH 4/4] Remove CPYCHECKER_RETURNS_BORROWED_REF Tom Tromey
2018-09-13 5:30 ` [PATCH 2/4] Change objfile_to_objfile_object to return a new reference Tom Tromey
2018-09-16 1:28 ` Simon Marchi
2018-09-16 2:00 ` Simon Marchi
2018-09-16 0:56 ` [PATCH 0/4] Disallow the return of borrowed references Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnxdo3p5.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox