From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/4] Change pspace_to_pspace_object to return a new reference
Date: Sun, 16 Sep 2018 00:57:00 -0000 [thread overview]
Message-ID: <435d6db2-bbe9-7f79-3e3d-55ca8f2da0bc@simark.ca> (raw)
In-Reply-To: <20180913053007.11780-2-tom@tromey.com>
On 2018-09-13 1:30 a.m., Tom Tromey wrote:
> diff --git a/gdb/python/py-objfile.c b/gdb/python/py-objfile.c
> index c2b40ff5352..8fd160c7bf8 100644
> --- a/gdb/python/py-objfile.c
> +++ b/gdb/python/py-objfile.c
> @@ -167,10 +167,8 @@ objfpy_get_progspace (PyObject *self, void *closure)
>
> if (obj->objfile)
> {
> - PyObject *pspace = pspace_to_pspace_object (obj->objfile->pspace);
> -
> - Py_XINCREF (pspace);
> - return pspace;
> + gdbpy_ref<> pspace = pspace_to_pspace_object (obj->objfile->pspace);
> + return pspace.get ();
> }
Can you double check this, shouldn't it be .release()? Otherwise, LGTM.
Simon
next prev parent reply other threads:[~2018-09-16 0:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 5:30 [PATCH 0/4] Disallow the return of borrowed references Tom Tromey
2018-09-13 5:30 ` [PATCH 4/4] Remove CPYCHECKER_RETURNS_BORROWED_REF Tom Tromey
2018-09-13 5:30 ` [PATCH 2/4] Change objfile_to_objfile_object to return a new reference Tom Tromey
2018-09-16 1:28 ` Simon Marchi
2018-09-16 2:00 ` Simon Marchi
2018-09-13 5:30 ` [PATCH 1/4] Change pspace_to_pspace_object " Tom Tromey
2018-09-16 0:57 ` Simon Marchi [this message]
2018-09-16 12:59 ` Tom Tromey
2018-09-16 1:19 ` Simon Marchi
2018-09-16 1:58 ` Simon Marchi
2018-09-16 13:01 ` Tom Tromey
2018-09-13 5:30 ` [PATCH 3/4] Change thread_to_thread_object " Tom Tromey
2018-09-16 2:11 ` Simon Marchi
2018-09-16 13:32 ` Tom Tromey
2018-09-16 14:05 ` Tom Tromey
2018-09-16 15:35 ` Tom Tromey
2018-09-17 0:52 ` Simon Marchi
2018-09-17 5:31 ` Tom Tromey
2018-09-16 0:56 ` [PATCH 0/4] Disallow the return of borrowed references Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=435d6db2-bbe9-7f79-3e3d-55ca8f2da0bc@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox