Re: [PATCH v2 0/3] Update FreeBSD's syscall table

[Sergio Durigan Junior <sergiodj@redhat.com>]

On Tuesday, November 06 2018, John Baldwin wrote:

> Relative to the first version of this patch series, I've fixed some
> nits noted by reviewers.  One thing I have not changed is I chose to
> keep the changed API of returning a vector of integers from
> get_syscalls_by_name().  I have expanded the comment in xml-syscall.h
> a bit to be more clear on why it returns a vector of integers.
>
> I also added a new patch (patch 1) to change the similar
> get_syscalls_by_group() to return a vector of integers instead of an
> allocated array of structures.  This results in more symmetry in the
> final code in break-catch-syscall.c.  There wasn't a very clean way to
> share the bits of duplicated code however.

I've read the patch series again, and it looks fine to me.  I'm still
not 100% happy with get_syscalls_by_name returning a vector, but this is
a minor thing (and a personal preference) and shouldn't block the patch.
Thanks for addressing the comments I've made, and sorry for not replying
to you e-mail (for some reason, I didn't get it in my INBOX).

I am not a global maintainer, BTW.

> John Baldwin (3):
>   Return a vector of integers from get_syscalls_by_group.
>   Add an optional "alias" attribute to syscall entries.
>   Update the FreeBSD system call table to match FreeBSD 12.0.
>
>  gdb/ChangeLog                  |  37 ++++++++++++
>  gdb/break-catch-syscall.c      |  27 ++++-----
>  gdb/gdbarch.h                  |   3 -
>  gdb/gdbarch.sh                 |   3 -
>  gdb/syscalls/freebsd.xml       | 107 ++++++++++++++++++++++++++-------
>  gdb/syscalls/gdb-syscalls.dtd  |   1 +
>  gdb/syscalls/update-freebsd.sh |  77 ++++++++++++++++++++++++
>  gdb/xml-syscall.c              |  91 ++++++++++++----------------
>  gdb/xml-syscall.h              |  17 +++---
>  9 files changed, 258 insertions(+), 105 deletions(-)
>  create mode 100755 gdb/syscalls/update-freebsd.sh
>
> -- 
> 2.18.0

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/