From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28537 invoked by alias); 6 Nov 2018 18:49:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17899 invoked by uid 89); 6 Nov 2018 18:48:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=replying, Relative X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Nov 2018 18:48:06 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 414603082137; Tue, 6 Nov 2018 18:48:05 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1483266D55; Tue, 6 Nov 2018 18:48:05 +0000 (UTC) From: Sergio Durigan Junior To: John Baldwin Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 0/3] Update FreeBSD's syscall table References: <20181106175431.59832-1-jhb@FreeBSD.org> Date: Tue, 06 Nov 2018 18:49:00 -0000 In-Reply-To: <20181106175431.59832-1-jhb@FreeBSD.org> (John Baldwin's message of "Tue, 6 Nov 2018 09:54:28 -0800") Message-ID: <87pnvi2gbf.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00071.txt.bz2 On Tuesday, November 06 2018, John Baldwin wrote: > Relative to the first version of this patch series, I've fixed some > nits noted by reviewers. One thing I have not changed is I chose to > keep the changed API of returning a vector of integers from > get_syscalls_by_name(). I have expanded the comment in xml-syscall.h > a bit to be more clear on why it returns a vector of integers. > > I also added a new patch (patch 1) to change the similar > get_syscalls_by_group() to return a vector of integers instead of an > allocated array of structures. This results in more symmetry in the > final code in break-catch-syscall.c. There wasn't a very clean way to > share the bits of duplicated code however. I've read the patch series again, and it looks fine to me. I'm still not 100% happy with get_syscalls_by_name returning a vector, but this is a minor thing (and a personal preference) and shouldn't block the patch. Thanks for addressing the comments I've made, and sorry for not replying to you e-mail (for some reason, I didn't get it in my INBOX). I am not a global maintainer, BTW. > John Baldwin (3): > Return a vector of integers from get_syscalls_by_group. > Add an optional "alias" attribute to syscall entries. > Update the FreeBSD system call table to match FreeBSD 12.0. > > gdb/ChangeLog | 37 ++++++++++++ > gdb/break-catch-syscall.c | 27 ++++----- > gdb/gdbarch.h | 3 - > gdb/gdbarch.sh | 3 - > gdb/syscalls/freebsd.xml | 107 ++++++++++++++++++++++++++------- > gdb/syscalls/gdb-syscalls.dtd | 1 + > gdb/syscalls/update-freebsd.sh | 77 ++++++++++++++++++++++++ > gdb/xml-syscall.c | 91 ++++++++++++---------------- > gdb/xml-syscall.h | 17 +++--- > 9 files changed, 258 insertions(+), 105 deletions(-) > create mode 100755 gdb/syscalls/update-freebsd.sh > > -- > 2.18.0 -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/