From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/rust: Handle printing structures containing strings
Date: Thu, 02 May 2019 15:50:00 -0000 [thread overview]
Message-ID: <87pnp0yhxz.fsf@tromey.com> (raw)
In-Reply-To: <20190502145646.GU2737@embecosm.com> (Andrew Burgess's message of "Thu, 2 May 2019 15:56:46 +0100")
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
>> It took me a while to understand this, but I get it now. At first it
>> looked like this code was misplaced, but what's going on is that
>> rust_val_print_str only takes a value, so in a "val_print" context we
>> must reconstruct one.
Andrew> If you'd like to suggest some new words I'd be happy to include them.
Andrew> I spent too long trying to write a helpful comment here, and like you
Andrew> I wasn't really happy with what I ended up with....
I think it's fine and it was just me being a bit obtuse :-)
Tom
prev parent reply other threads:[~2019-05-02 15:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 23:52 Andrew Burgess
2019-05-02 13:44 ` Tom Tromey
2019-05-02 14:56 ` Andrew Burgess
2019-05-02 15:50 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnp0yhxz.fsf@tromey.com \
--to=tom@tromey.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox