From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116549 invoked by alias); 2 May 2019 15:50:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116531 invoked by uid 89); 2 May 2019 15:50:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.196.18) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 02 May 2019 15:50:04 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway30.websitewelcome.com (Postfix) with ESMTP id E8F00AA25 for ; Thu, 2 May 2019 10:50:02 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id MDyDhOb9M2PzOMDyDhsCRF; Thu, 02 May 2019 10:50:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=B5bMET4sJPi3KOrNcfUYRGUEapr3DVe8TvaKgpePHW0=; b=w5DgkMKAuZiL3TffZjtrFYt2UP YnmzifUoJLEh5wUAi2jYiPYXJEOARou6gAGVePGWtFoFhYX5T+IaGYa0N8m149PowzPKY/5AWQ/YP 5O0/FPgQRG2+CltB7PnwQF0xp; Received: from 97-122-168-123.hlrn.qwest.net ([97.122.168.123]:35240 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hMDyD-002fYI-GX; Thu, 02 May 2019 10:50:01 -0500 From: Tom Tromey To: Andrew Burgess Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/rust: Handle printing structures containing strings References: <20190501235246.7982-1-andrew.burgess@embecosm.com> <875zqtynrv.fsf@tromey.com> <20190502145646.GU2737@embecosm.com> Date: Thu, 02 May 2019 15:50:00 -0000 In-Reply-To: <20190502145646.GU2737@embecosm.com> (Andrew Burgess's message of "Thu, 2 May 2019 15:56:46 +0100") Message-ID: <87pnp0yhxz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-05/txt/msg00040.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: >> It took me a while to understand this, but I get it now. At first it >> looked like this code was misplaced, but what's going on is that >> rust_val_print_str only takes a value, so in a "val_print" context we >> must reconstruct one. Andrew> If you'd like to suggest some new words I'd be happy to include them. Andrew> I spent too long trying to write a helpful comment here, and like you Andrew> I wasn't really happy with what I ended up with.... I think it's fine and it was just me being a bit obtuse :-) Tom