From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 7/9] Change solib-aix.c to use type-safe registry
Date: Wed, 10 Jul 2019 20:34:00 -0000 [thread overview]
Message-ID: <87pnmhd3yi.fsf@tromey.com> (raw)
In-Reply-To: <c86cb991-50f7-50a0-cf60-52f1b5539e19@simark.ca> (Simon Marchi's message of "Wed, 10 Jul 2019 14:55:08 -0400")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>> +typedef gdb::optional<std::vector<lm_info_aix>> library_list_type;
Simon> Hmm, I find that hiding the gdb::optional behind a typedef can be a bit
Simon> confusing. It's easy to forget that it's an optional if it's not "in your
Simon> face". I think it would help to be explicit and spell out gdb::optional
Simon> where needed.
Makes sense, I've removed the typedef.
I made the other changes you mentioned, except...
>> - for (ix = 1; VEC_iterate (lm_info_aix_p, library_list, ix, info); ix++)
>> + for (ix = 1; ix < library_list->size (); ix++)
Simon> This could be:
Simon> for (lm_info_aix &info : *library_list)
This isn't quite the same, because the current loop starts at index 1,
not 0. So, I didn't make this change.
Tom
next prev parent reply other threads:[~2019-07-10 20:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 15:39 [PATCH 0/9] Use the type-safe registry in more cases Tom Tromey
2019-07-10 15:39 ` [PATCH 7/9] Change solib-aix.c to use type-safe registry Tom Tromey
2019-07-10 18:55 ` Simon Marchi
2019-07-10 20:34 ` Tom Tromey [this message]
2019-07-10 20:38 ` Simon Marchi
2019-07-10 15:39 ` [PATCH 2/9] Change solib-darwin.c " Tom Tromey
2019-07-10 15:39 ` [PATCH 6/9] Change solib-dsbt.c " Tom Tromey
2019-07-10 15:39 ` [PATCH 8/9] Change solib-spu.c " Tom Tromey
2019-07-10 15:39 ` [PATCH 3/9] Change jit.c " Tom Tromey
2019-07-10 17:02 ` Simon Marchi
2019-07-10 18:44 ` Tom Tromey
2019-07-10 15:39 ` [PATCH 1/9] Change remote-sim.c " Tom Tromey
2019-07-10 16:59 ` Simon Marchi
2019-07-10 17:03 ` Tom Tromey
2019-07-10 15:49 ` [PATCH 4/9] Change dbxread.c " Tom Tromey
2019-07-10 15:49 ` [PATCH 9/9] Change arm-tdep.c " Tom Tromey
2019-07-10 19:03 ` [PATCH 0/9] Use the type-safe registry in more cases Simon Marchi
2019-07-10 20:34 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnmhd3yi.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox