From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114630 invoked by alias); 10 Jul 2019 20:34:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114621 invoked by uid 89); 10 Jul 2019 20:34:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Jul 2019 20:34:00 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AD00A56012; Wed, 10 Jul 2019 16:33:58 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id nKu0Cdo+J7Ik; Wed, 10 Jul 2019 16:33:58 -0400 (EDT) Received: from murgatroyd (97-122-178-82.hlrn.qwest.net [97.122.178.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 34A4856010; Wed, 10 Jul 2019 16:33:58 -0400 (EDT) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 7/9] Change solib-aix.c to use type-safe registry References: <20190710153947.25721-1-tromey@adacore.com> <20190710153947.25721-8-tromey@adacore.com> Date: Wed, 10 Jul 2019 20:34:00 -0000 In-Reply-To: (Simon Marchi's message of "Wed, 10 Jul 2019 14:55:08 -0400") Message-ID: <87pnmhd3yi.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-07/txt/msg00281.txt.bz2 >>>>> "Simon" == Simon Marchi writes: >> +typedef gdb::optional> library_list_type; Simon> Hmm, I find that hiding the gdb::optional behind a typedef can be a bit Simon> confusing. It's easy to forget that it's an optional if it's not "in your Simon> face". I think it would help to be explicit and spell out gdb::optional Simon> where needed. Makes sense, I've removed the typedef. I made the other changes you mentioned, except... >> - for (ix = 1; VEC_iterate (lm_info_aix_p, library_list, ix, info); ix++) >> + for (ix = 1; ix < library_list->size (); ix++) Simon> This could be: Simon> for (lm_info_aix &info : *library_list) This isn't quite the same, because the current loop starts at index 1, not 0. So, I didn't make this change. Tom