Re: [PATCH] Include s12z-opc.h using ..

[Tom Tromey <tom@tromey.com>]

>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:

Christian> I must be missing something; I don't see how this can compile?
Christian> This file exists in binutils-gdb/opcodes, and as far as I can tell
Christian> nothing in Makefile.in adds this to the include path. This patch
Christian> makes my compile work (when using --enable-targets=all).

This patch made me realize that moving gdbsupport to top-level is going
to run into this same issue.  I hadn't considered the
--with-system-readline case here :-(

I thought of 3 options:

1. Move all the gdbsupport headers into a subdirectory, either of
   gdbsupport or include.

2. Add a -I for gdbsupport and change how the #includes are written --
   dropping the "gdbsupport/" part.

3. Make a new "readline/readline" directory and move the contents there,
   similar to what is done for gnulib.

On the whole I lean toward plan 3, because it would also let us handle
opcodes includes in a less ugly way.

Tom