From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92896 invoked by alias); 2 Aug 2019 18:22:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92886 invoked by uid 89); 2 Aug 2019 18:22:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Aug 2019 18:22:12 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway31.websitewelcome.com (Postfix) with ESMTP id C0532842095 for ; Fri, 2 Aug 2019 13:20:41 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id tcAThi2ER3Qi0tcAThS5XN; Fri, 02 Aug 2019 13:20:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=AHo91npS3yjqMQcoX6mfcBw1ks7qecAhl2Mj9sPJXUI=; b=Y1S/XNXyjiUCTNocNy2CObVgQE 53Os2wCAAdA40acLRETIkG1I3gSkjNHl3pH7Nx/mKl2u6xzlAaNIDzaDHnEUvyYzJaQMJXTTT5Jbv w7UK4rRk0N1s14jpPzB15jkAq; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:36988 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1htcAT-002qRe-FB; Fri, 02 Aug 2019 13:20:41 -0500 From: Tom Tromey To: Gdb Patches Subject: Re: [PATCH] Include s12z-opc.h using .. References: <20190801170141.198456-1-cbiesinger@google.com> Date: Fri, 02 Aug 2019 18:22:00 -0000 In-Reply-To: <20190801170141.198456-1-cbiesinger@google.com> (Christian Biesinger via gdb-patches's message of "Thu, 1 Aug 2019 12:01:41 -0500") Message-ID: <87pnlne8ef.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-08/txt/msg00053.txt.bz2 >>>>> "Christian" == Christian Biesinger via gdb-patches writes: Christian> I must be missing something; I don't see how this can compile? Christian> This file exists in binutils-gdb/opcodes, and as far as I can tell Christian> nothing in Makefile.in adds this to the include path. This patch Christian> makes my compile work (when using --enable-targets=all). This patch made me realize that moving gdbsupport to top-level is going to run into this same issue. I hadn't considered the --with-system-readline case here :-( I thought of 3 options: 1. Move all the gdbsupport headers into a subdirectory, either of gdbsupport or include. 2. Add a -I for gdbsupport and change how the #includes are written -- dropping the "gdbsupport/" part. 3. Make a new "readline/readline" directory and move the contents there, similar to what is done for gnulib. On the whole I lean toward plan 3, because it would also let us handle opcodes includes in a less ugly way. Tom