Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org,
	 Simon Marchi <smarchi@dev-macosx-01.internal.efficios.com>
Subject: Re: [PATCH] gdb: fix darwin-nat.c build / adapt to multi-target
Date: Thu, 23 Jan 2020 18:14:00 -0000	[thread overview]
Message-ID: <87pnfaxdl8.fsf@tromey.com> (raw)
In-Reply-To: <20200123165938.32116-1-simon.marchi@efficios.com> (Simon	Marchi's message of "Thu, 23 Jan 2020 11:59:38 -0500")

>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:

Simon> I don't have much more time to put on this to figure it out, so I
Simon> thought I'd sent the patch anyway, as it's at least a step in the
Simon> right direction.

I read through this patch and it all looks reasonable to me.  And, since
having it build is better than having it not build, I think you should
check it in.

thanks,
Tom


  parent reply	other threads:[~2020-01-23 17:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-23 17:02 Simon Marchi
2020-01-23 17:10 ` Simon Marchi
2020-01-23 18:14 ` Tom Tromey [this message]
2020-01-23 18:21 ` Pedro Alves
2020-01-23 20:59   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pnfaxdl8.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@efficios.com \
    --cc=smarchi@dev-macosx-01.internal.efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox