From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21360 invoked by alias); 23 Jan 2020 17:55:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21345 invoked by uid 89); 23 Jan 2020 17:55:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.50.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Jan 2020 17:55:01 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 3C56BB8193 for ; Thu, 23 Jan 2020 11:55:00 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ugh2ijLy732Adugh2iskKU; Thu, 23 Jan 2020 11:55:00 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+lfaZyvZyTNerL9mkzNSqSR2QtaakQhvnZaApZF5CcQ=; b=aXP6ycZiPwFKnJfSpGr/iuDlLL atH3w4fQYeOIKKtyb0Jzbowci0dK6RAqTydiJYsUrj7VW2YTxYJsSqlw1nDLsRwYvqeqxL9aoVm3U 0cHgLjxWX+5kGU65cM72iM2OY; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:40778 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iugh2-003piu-08; Thu, 23 Jan 2020 10:55:00 -0700 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH] gdb: fix darwin-nat.c build / adapt to multi-target References: <20200123165938.32116-1-simon.marchi@efficios.com> Date: Thu, 23 Jan 2020 18:14:00 -0000 In-Reply-To: <20200123165938.32116-1-simon.marchi@efficios.com> (Simon Marchi's message of "Thu, 23 Jan 2020 11:59:38 -0500") Message-ID: <87pnfaxdl8.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-01/txt/msg00741.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> I don't have much more time to put on this to figure it out, so I Simon> thought I'd sent the patch anyway, as it's at least a step in the Simon> right direction. I read through this patch and it all looks reasonable to me. And, since having it build is better than having it not build, I think you should check it in. thanks, Tom