Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: "Sharma, Alok Kumar" <AlokKumar.Sharma@amd.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	 "George, Jini Susan" <JiniSusan.George@amd.com>,
	 "Achra, Nitika" <Nitika.Achra@amd.com>
Subject: Re: [PATCH] Fix for incorrect breakpoint set in case of flang compiled binary
Date: Mon, 17 Aug 2020 14:51:19 -0600	[thread overview]
Message-ID: <87pn7puhbs.fsf@tromey.com> (raw)
In-Reply-To: <DM5PR12MB1644DE2B0B657A79E1920A749E5F0@DM5PR12MB1644.namprd12.prod.outlook.com> (Alok Kumar Sharma's message of "Mon, 17 Aug 2020 15:17:02 +0000")

>>>>> ">" == Sharma, Alok Kumar <AlokKumar.Sharma@amd.com> writes:

>> +	          || startswith(COMPUNIT_PRODUCER(cust), " F90 Flang"))))

Space before "(".

Does it really start with a space?  That seems weird.

>>  # Check if not allocated VLA in type does not break
>>  # the debugger when accessing it.
>> -gdb_breakpoint [gdb_get_line_number "before-allocated"]
>> -gdb_continue_to_breakpoint "before-allocated"
>> +# break main for Flang compiler already breaks here

Do you know why?

Tom


  reply	other threads:[~2020-08-17 20:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-17 15:17 Sharma, Alok Kumar
2020-08-17 20:51 ` Tom Tromey [this message]
2020-08-19 13:05   ` Andrew Burgess
2020-08-18 10:29 ` Andrew Burgess
2020-08-18 12:53   ` Sharma, Alok Kumar
2020-08-19 13:09     ` Andrew Burgess
2020-08-19 15:25       ` Sharma, Alok Kumar
2020-08-18 19:21   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pn7puhbs.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=AlokKumar.Sharma@amd.com \
    --cc=JiniSusan.George@amd.com \
    --cc=Nitika.Achra@amd.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox