Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: "Sharma, Alok Kumar" <AlokKumar.Sharma@amd.com>,
	 "George, Jini Susan" <JiniSusan.George@amd.com>,
	 "Achra, Nitika" <Nitika.Achra@amd.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix for incorrect breakpoint set in case of flang compiled binary
Date: Tue, 18 Aug 2020 13:21:08 -0600	[thread overview]
Message-ID: <87mu2rahgb.fsf@tromey.com> (raw)
In-Reply-To: <20200818102903.GL853475@embecosm.com> (Andrew Burgess's message of "Tue, 18 Aug 2020 11:29:03 +0100")

Andrew> We have the files producer.{c,h} that wrap up tests just like this
Andrew> one.  If feels like we should add a new test to those files that
Andrew> matches all clang backend based compilers, then make use of this new
Andrew> test throughout.

Andrew> I'd keep the name of the test fairly generic, the important thing here
Andrew> is the backend technology right, not the frontend language?  So if I
Andrew> added a new language with a clang backend I'd likely run into the same
Andrew> issues.

See also the hilarious

https://github.com/rust-lang/rust/issues/41252#issuecomment-293676579

Also

https://sourceware.org/bugzilla/show_bug.cgi?id=21470

Whenever this comes up, I think to myself that gdb should assume correct
DWARF by default, and have to sniff for the compilers that break the
rules -- mostly GCC I suppose :-( 

Tom


      parent reply	other threads:[~2020-08-18 19:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-17 15:17 Sharma, Alok Kumar
2020-08-17 20:51 ` Tom Tromey
2020-08-19 13:05   ` Andrew Burgess
2020-08-18 10:29 ` Andrew Burgess
2020-08-18 12:53   ` Sharma, Alok Kumar
2020-08-19 13:09     ` Andrew Burgess
2020-08-19 15:25       ` Sharma, Alok Kumar
2020-08-18 19:21   ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mu2rahgb.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=AlokKumar.Sharma@amd.com \
    --cc=JiniSusan.George@amd.com \
    --cc=Nitika.Achra@amd.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox