Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>, sourcewarebugz@kyber.fi
Subject: Re: [PATCH] gdb: check for empty strings in get_standard_cache_dir/get_standard_config_dir
Date: Thu, 07 Jan 2021 14:00:30 -0700	[thread overview]
Message-ID: <87pn2gv4wh.fsf@tromey.com> (raw)
In-Reply-To: <20210107205725.2010353-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Thu, 7 Jan 2021 15:57:25 -0500")

>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> gdb_abspath doesn't handle empty strings, so handle this case in the
Simon> callers.  If a variable is defined but empty, I think it's reasonable in
Simon> this case to just ignore it, as if it was not defined.

Makes sense to me.

For XDG, I read here:

    https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html

this:

    All paths set in these environment variables must be absolute. If an
    implementation encounters a relative path in any of these variables it
    should consider the path invalid and ignore it.

So I suppose we could go a bit further here.

Tom

  reply	other threads:[~2021-01-07 21:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-07 20:57 Simon Marchi via Gdb-patches
2021-01-07 21:00 ` Tom Tromey [this message]
2021-01-07 21:14   ` Simon Marchi via Gdb-patches
2021-01-07 21:43     ` Lancelot SIX via Gdb-patches
2021-01-07 21:53       ` Simon Marchi via Gdb-patches
2021-01-07 22:04         ` Lancelot SIX via Gdb-patches
2021-01-07 22:10           ` Simon Marchi via Gdb-patches
2021-01-07 23:39         ` Sergio Durigan Junior via Gdb-patches
2021-01-08  9:45       ` Andrew Burgess
2021-01-08 11:05     ` Christian Biesinger via Gdb-patches
2021-01-08  9:48 ` Andrew Burgess
2021-01-08 15:50   ` [PATCH v2] gdb: check for empty strings in, get_standard_cache_dir/get_standard_config_dir Simon Marchi via Gdb-patches
2021-01-08 17:13     ` Andrew Burgess
2021-01-08 18:47       ` Simon Marchi via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pn2gv4wh.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@efficios.com \
    --cc=sourcewarebugz@kyber.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox