From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YEXzJXR291+dEwAAWB0awg (envelope-from ) for ; Thu, 07 Jan 2021 16:00:36 -0500 Received: by simark.ca (Postfix, from userid 112) id 9961C1E965; Thu, 7 Jan 2021 16:00:36 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B326D1E590 for ; Thu, 7 Jan 2021 16:00:34 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 26D1C396DC37; Thu, 7 Jan 2021 21:00:34 +0000 (GMT) Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.46.194]) by sourceware.org (Postfix) with ESMTPS id D5103386F457 for ; Thu, 7 Jan 2021 21:00:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D5103386F457 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 601637424 for ; Thu, 7 Jan 2021 15:00:31 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id xcOVkrfdeiQiZxcOVkWLdG; Thu, 07 Jan 2021 15:00:31 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fpYrUPChUqhwTbjWMeGAvEzoBXxfi4Z4ogJWY6T/2fo=; b=iR7WOU0PjeIx0XgDXzFeQDoSvL UF5gaas2rNIWVsOcmtVokNJwYID/LnSlvgeKKymavf8YcSrAZxZ4JXWMaUKDYESDz5OzgmdzTFLoG XIntdCSIB3O7YWALXeldtss/2; Received: from 97-122-81-39.hlrn.qwest.net ([97.122.81.39]:42004 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kxcOV-000ynd-0C; Thu, 07 Jan 2021 14:00:31 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Subject: Re: [PATCH] gdb: check for empty strings in get_standard_cache_dir/get_standard_config_dir References: <20210107205725.2010353-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Thu, 07 Jan 2021 14:00:30 -0700 In-Reply-To: <20210107205725.2010353-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Thu, 7 Jan 2021 15:57:25 -0500") Message-ID: <87pn2gv4wh.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.81.39 X-Source-L: No X-Exim-ID: 1kxcOV-000ynd-0C X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-81-39.hlrn.qwest.net (murgatroyd) [97.122.81.39]:42004 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Simon Marchi , sourcewarebugz@kyber.fi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> gdb_abspath doesn't handle empty strings, so handle this case in the Simon> callers. If a variable is defined but empty, I think it's reasonable in Simon> this case to just ignore it, as if it was not defined. Makes sense to me. For XDG, I read here: https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html this: All paths set in these environment variables must be absolute. If an implementation encounters a relative path in any of these variables it should consider the path invalid and ignore it. So I suppose we could go a bit further here. Tom