Re: [PATCH v4] gdb: redo whitespace-stripping from commands

[Andrew Burgess <aburgess@redhat.com>]

"Kartik K. Agaram" <ak@akkartik.com> writes:

> Before this patch, trailing whitespace was not stripped from 'set' and
> 'complete' commands. Now I've added 'with' to that list of commands
> because it may contain one of those commands. To accomplish this, I'm
> fixing an ancient TODO to provide a per-command flag controlling
> whitespace-stripping.
>
> Any subcommands of 'with' besides 'complete' or 'set' will continue to
> strip whitespace as before, because they go through a recursive call to
> execute_command. The outer call for 'with' won't strip whitespace, then
> the recursive call will.
>
> I've also cleaned up 2 obsolete TODOs and NOTEs in related code.
>
> Tested on x86_64-linux.
>
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29784
> Reviewed-By: Guinevere Larsen <guinevere@redhat.com>
> ---
> Changes for v4:
> * Ugh, removed a stray quote character from the commit description.
>
>  gdb/cli/cli-cmds.c   | 11 ++++-------
>  gdb/cli/cli-cmds.h   |  4 ----
>  gdb/cli/cli-decode.c |  1 +
>  gdb/cli/cli-decode.h |  8 ++++----
>  gdb/top.c            | 12 +-----------
>  5 files changed, 10 insertions(+), 26 deletions(-)

It feels like this commit could have some tests added.  There is a
support library 'completion-support.exp', if you look for the pattern
'load_lib completion-support.exp' in the testsuite then you'll find
plenty of examples of its use.

Do take care though, there are some completion tests that pre-date the
completion-support.exp library -- if you find a test that is manually
sending tabs to GDB without using the support library, then it's
probably an older test, and not a good example to learn from.

Unfortunately, completion tests are towards the harder end of tests to
write (I find anyway), but I think it is worth doing.  Do feel free to
ask if you get stuck.

Thanks,
Andrew