From: "Kartik K. Agaram" <ak@akkartik.com>
To: gdb-patches@sourceware.org
Cc: guinevere@redhat.com
Subject: gdb: redo whitespace-stripping from commands
Date: Sat, 31 May 2025 18:17:10 -0700 [thread overview]
Message-ID: <20250601011941.204158-1-ak@akkartik.com> (raw)
In-Reply-To: <20250529125138.1118538-1-ak@akkartik.com>
All tests pass now.
> Open question: This patch stops stripping trailing whitespace from all
> 'with' commands. Might that create issues with other 'with' commands besides
> 'with ... -- complete'?
I've answered this question to my satisfaction. 'with' recursively calls
execute_command, so other 'with' commands besides 'set' or 'complete' will
result in the following timeline of events:
execute_command()
- command is 'with' so don't strip whitespace
- execute_command()
- command is not 'with' or 'set' or 'complete' so strip whitespace
- ...
next prev parent reply other threads:[~2025-06-01 1:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-29 12:51 [PATCH] RFC: " Kartik K. Agaram
2025-05-29 13:36 ` Tom Tromey
2025-05-29 13:53 ` Kartik Agaram
2025-05-29 13:53 ` Guinevere Larsen
2025-05-29 13:59 ` Kartik Agaram
2025-05-29 15:35 ` Tom Tromey
2025-06-01 1:17 ` Kartik K. Agaram [this message]
2025-06-01 1:17 ` [PATCH] " Kartik K. Agaram
2025-06-02 16:30 ` Guinevere Larsen
2025-06-02 16:42 ` Kartik Agaram
2025-06-02 23:39 ` [PATCH v3] " Kartik K. Agaram
2025-06-06 16:10 ` [PATCH v4] " Kartik K. Agaram
2025-07-07 17:59 ` Kartik Agaram
2025-07-08 9:27 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250601011941.204158-1-ak@akkartik.com \
--to=ak@akkartik.com \
--cc=gdb-patches@sourceware.org \
--cc=guinevere@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox