Re: [PATCH v3] gdb/aarch64: record/replay support for LRCPC3

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

Guinevere Larsen <guinevere@redhat.com> writes:

> On 5/29/26 8:01 PM, Ezra.Sitorus@arm.com wrote:
>> From: Ezra Sitorus <ezra.sitorus@arm.com>
>>
>> FEAT_LRCPC3 introduces various load/store instructions with release
>> consistency for cases where ordering is required. This patch teaches GDB
>> to decode these instructions for recording and reversing.
>>
>> The gdb.reverse/aarch64-lrcpc3.exp testcase verifies that the
>> instructions are recorded and correctly reversed. In particular, there
>> are some interesting cases to note:
>> * ldapur/stlur are SIMD instructions, but are not decoded in the simd
>>    function.
>> * There are writeback cases to cover too. These were taken from the
>>    binutils testcases: gas/testsuite/gas/aarch64/rcpc3.s.
>>
>> The full testsuite was done on aarch64-none-linux-gnu without LRCPC3.
>> The gdb.arch and gdb.reverse tests were run on Shrinkwrap with LRCPC3
>> support.
>>
>> Please note:
>> 1) There is no support for LRCPC and LRCPC2 instructions
>> 2) LRCPC3 is gated with +rcpc3 in GCC/binutils and LLVM.
>>
>> ---
>
> This looks ready to go in from the record-full side. Feel free to add my tag
>
> Approved-By: Guinevere Larsen <guinevere@redhat.com> (record-full)
>
> You should wait for Luis's or Thiago's approval for the aarch64 parts before pushing it,
> though, as I only approved the test parts and ack the changes to the recording part

Thank you Guinevere for the review, and thank you Ezra for v3.
This version looks good to me.

Approved-by: Thiago Jung Bauermann <thiago.bauermann@linaro.org>

-- 
Thiago
(he/him)