From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id DB6xEpYDHmp4gS4AWB0awg (envelope-from ) for ; Mon, 01 Jun 2026 18:11:34 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Zis8iRfj; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3CADC1E0A3; Mon, 01 Jun 2026 18:11:34 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3581D1E024 for ; Mon, 01 Jun 2026 18:11:33 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ADA4B4BA2E2B for ; Mon, 1 Jun 2026 22:11:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ADA4B4BA2E2B Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Zis8iRfj Received: from mail-vs1-xe33.google.com (mail-vs1-xe33.google.com [IPv6:2607:f8b0:4864:20::e33]) by sourceware.org (Postfix) with ESMTPS id 4418A4BA2E19 for ; Mon, 1 Jun 2026 22:10:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4418A4BA2E19 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4418A4BA2E19 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::e33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780351856; cv=none; b=Ri5ia/qm4Do5gkEn6Vr5uzpebjHbvUiEJ9H5sI6la12oW3z4bT3SOXOOPlj1mJiWtSb5g723jMCDHEU9bxsRsEkhhTtRun9iEkwX8jv47ZIxGCy7q8iqPBqSMm5SM2bO9Id7e9aP5u24aFJvOj14nY4ylqFURB8DEg30miTgVFo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780351856; c=relaxed/simple; bh=+Z2thelRRCkxgWlJhaCTnxXRXmKbhjQ7LqyXYUwFwSU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=LHtEj1nQfH5E73b1ZLxlOMo9jKcKIKb2ebxjyUFeEdQpqHVSymlgLshgeT+Xj74kIKnmCayAGFJIu0lh7fNoXgbwq5nBT5nIaU6pqUZL220jQaQVEb4WStQ/FBk0chEsYj/3PE+DrVLYcKxazmbbAbzYDq/H33TuaBkCLs7Kw24= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Zis8iRfj DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4418A4BA2E19 Received: by mail-vs1-xe33.google.com with SMTP id ada2fe7eead31-6c7e8c9f612so954746137.0 for ; Mon, 01 Jun 2026 15:10:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1780351856; x=1780956656; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ypemEoL+8NvMiootthYf/H7j/xqYIvKsEocEtJZlxKA=; b=Zis8iRfjKxlQ3NNcA4b2a+wglqNqD+ZN4V72Ia19Q9g7UyzVrWcBMI3TJpXTNlo3jx Hy6/QNUz+w1+6p3pHcmPFfEqaiwwqPc64vLj2ItvAjaw957S/mpZYraIMzHdit7SUtjU EnTdvDMO123GQNUgC/E1qhDCypQT4tZ6NBsTSbrllbpQeRAe48NI+gSQj1NHlenXnMMy A+JIPF7chDBBGcbpsI3raPr1/7PBBfX+eGmMcEjl2ZwLmC5J2as4QfFvA8nyhjviElAw oLsldbD2GFm1pJy4tdQBtV+0qLWvcOwvB8fhzNFgp7kIDJq/mLHOF9hSlVZln/Thlipb iAAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780351856; x=1780956656; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ypemEoL+8NvMiootthYf/H7j/xqYIvKsEocEtJZlxKA=; b=OsmPL0YfqErS/F43jXUgFcAHF/J4QH8lTKVemuq1HyJYu7WKtH2aqT0mgqxrtx3JRF nEs8LsaJOz2HOD4LhpgMAkfF5mKu2sAQ6YWPGur70VNktTuhu6iqYzG7+JKfJSQBaWhT Xh1OQRzdxrgVsQRi//R3Jt2BGZtimuKQS5S9O9foY9NYHc3dMVUpnzJ1x55QtBJnSWnL +d8kO1qhIcEpINtSjv3rdBfl4Qs+WRtTETnyqs2UkxpIzqgkjudQdHAlr+XYPmZ5xfPP i/qQQTMp4m+4zE/zyQylBWG6I6Z+iCzA8J/OR0iCUjD6LJKUy6qc5KVdM/OBc02UmAZ3 kn1Q== X-Forwarded-Encrypted: i=1; AFNElJ8Z/Y6ioggjTeaSWxLqhY4VoD8OBHve+p/C1CTIvJ83PM3egObJPlNgxYo9y2c46JZdRD8Zylmkl9SbrA==@sourceware.org X-Gm-Message-State: AOJu0YxdxFPRjy5W3BbXBDjYueUUfs4UKuXNGQb5Dr4Lc19zHAzut3KX qXbLndQcNuM+xroflaGVV6AHRtDq1Q2HIRSIC/MqmpNgSZXcl+dhpP7/FL2CS2RPF7c= X-Gm-Gg: Acq92OEJF0PEjB/AzN35g7rHUWxnLmSKg3dg1daKTIbruooL9VlBA2BMZje8WDEMieF JDZd2cyFrFRtIdva3HCAGxhMvEkezx31xT+PVRxCWWCVYvYyqFH46iJowiJDAJJ1vvQQH1ztIqU 0zERh/T2JTBKEVtglyqDma0O4EMEtZrgDgfkqfeX5nn0r5qs4gPM5ikS1Lpv5fAihsYsKO2OlND Wps/7I0aMog0c1iDn6aJuPbcKYnHKoBjNn/8cM9yMgSGUxsHYLXe6uLCMGlwbjXBI3zbAJqwhI2 XCUmAsqWm2ADxhuoE7IwDKx73qb1GBrQBkiXDSZiqmjScm1M4qQdaFsQYa7sqJmc0OB0S0svfa3 bog97JTgEE7DHM9Q8DEUvTRWAj8IGB66HlkorikPe+bn7tCfi6jSLo8pPmwdIFkjRbEp0cFRUtT LeEIVODgWXw3zMY5oQItqD0HuckH6roofTbCQq/GWmrtoKSrXXMF8hsaU= X-Received: by 2002:a05:6102:c13:b0:632:425e:85eb with SMTP id ada2fe7eead31-6c69a5e9bfdmr5827751137.21.1780351855510; Mon, 01 Jun 2026 15:10:55 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-6bfbaa7fcd6sm7789641137.5.2026.06.01.15.10.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 15:10:55 -0700 (PDT) From: Thiago Jung Bauermann To: Ezra.Sitorus@arm.com, gdb-patches@sourceware.org Cc: luis.machado.foss@gmail.com, Guinevere Larsen Subject: Re: [PATCH v3] gdb/aarch64: record/replay support for LRCPC3 In-Reply-To: <8d8de19a-4fa0-4f07-aefd-feaf41a7af62@redhat.com> (Guinevere Larsen's message of "Mon, 1 Jun 2026 10:21:37 -0300") References: <20260529230109.4123-1-Ezra.Sitorus@arm.com> <8d8de19a-4fa0-4f07-aefd-feaf41a7af62@redhat.com> User-Agent: mu4e 1.14.1; emacs 30.2 Date: Mon, 01 Jun 2026 22:10:52 +0000 Message-ID: <87pl29oqs3.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Guinevere Larsen writes: > On 5/29/26 8:01 PM, Ezra.Sitorus@arm.com wrote: >> From: Ezra Sitorus >> >> FEAT_LRCPC3 introduces various load/store instructions with release >> consistency for cases where ordering is required. This patch teaches GDB >> to decode these instructions for recording and reversing. >> >> The gdb.reverse/aarch64-lrcpc3.exp testcase verifies that the >> instructions are recorded and correctly reversed. In particular, there >> are some interesting cases to note: >> * ldapur/stlur are SIMD instructions, but are not decoded in the simd >> function. >> * There are writeback cases to cover too. These were taken from the >> binutils testcases: gas/testsuite/gas/aarch64/rcpc3.s. >> >> The full testsuite was done on aarch64-none-linux-gnu without LRCPC3. >> The gdb.arch and gdb.reverse tests were run on Shrinkwrap with LRCPC3 >> support. >> >> Please note: >> 1) There is no support for LRCPC and LRCPC2 instructions >> 2) LRCPC3 is gated with +rcpc3 in GCC/binutils and LLVM. >> >> --- > > This looks ready to go in from the record-full side. Feel free to add my tag > > Approved-By: Guinevere Larsen (record-full) > > You should wait for Luis's or Thiago's approval for the aarch64 parts before pushing it, > though, as I only approved the test parts and ack the changes to the recording part Thank you Guinevere for the review, and thank you Ezra for v3. This version looks good to me. Approved-by: Thiago Jung Bauermann -- Thiago (he/him)