From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Wrap (and poison) PyObject_CallFunctionObjArgs
Date: Mon, 14 Sep 2026 16:15:53 -0600 [thread overview]
Message-ID: <87pkyf5vja.fsf@tromey.com> (raw)
In-Reply-To: <7288831a-098e-486d-8c02-088a2e1affc3@simark.ca> (Simon Marchi's message of "Mon, 14 Sep 2026 16:09:20 -0400")
>> +/* Poison PyObject_CallFunctionObjArgs. The typesafe wrapper
>> + gdbpy_objects_call_function_obj_args should be used instead. */
Simon> Typo, gdbpy_objects_call_function_obj_ar -> gdbpy_object_call_function_obj_args
I fixed it.
>> +#undef PyObject_CallFunctionObjArgs
>> +#ifdef __GNUC__
>> +# pragma GCC poison PyObject_CallFunctionObjArgs
>> +#else
>> +# define PyObject_CallFunctionObjArgs POISONED_PyObject_CallFunctionObjArgs
>> +#endif
Simon> Clang appears to support "pragma GCC poison", could we use it
Simon> unconditionnaly?
I don't know. I just copied similar code from elsewhere in the file.
Tom
prev parent reply other threads:[~2026-09-14 22:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 19:06 Tom Tromey
2026-09-14 20:09 ` Simon Marchi
2026-09-14 22:15 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pkyf5vja.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox