From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yRzNFj5yqGq/Bg0AWB0awg (envelope-from ) for ; Mon, 14 Sep 2026 18:16:30 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=IGjd7Vmi; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 58CE21E051; Mon, 14 Sep 2026 18:16:30 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 828EA1E051 for ; Mon, 14 Sep 2026 18:16:29 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5C5B64B99F53 for ; Mon, 14 Sep 2026 22:16:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5C5B64B99F53 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=IGjd7Vmi Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 4BC744BAE7F2 for ; Mon, 14 Sep 2026 22:15:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4BC744BAE7F2 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4BC744BAE7F2 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789424157; cv=none; b=C0d7Bt+TgsZqjIUbk2hdQwjvVswnZaAYpri8R04bi3K8QeEXVb+MbRcLGhCB0RE4d91z/Ei0G56mb5HNSTx/zGGCWIm79+/Au7XsVnGnnHXGv5d8G8V6ukaJ6RBWdWpY5dXuNTxTj4bUQ4/4SDRcX2afXzieLyiKI8o+I/lVJjI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789424157; c=relaxed/simple; bh=0uPnHyuHQciEQUKcJZXXR7UM18Ykcr60tlmerizqdA8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=oAEpCbOuqnN6o5EvueP0nkISScpGyplyFJOXUhJRMAwlLzx4OYkHH/n2QhFRx9KQQmCPWBrj7CJeMoxSrIJzO5clxUSZo/9qbvFc/gNeB0k0gPET7ETPSKsioshEZWd3fQwrnsNBEwHBm10esfy71nTGOijQJeO0Y8dq+Ua4xy4= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=IGjd7Vmi reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4BC744BAE7F2 Received: from eig-obgw-6006b.ext.cloudfilter.net ([10.0.30.211]) by cmsmtp with ESMTPS id 6ByWxxjUMaC0U6Exwx129i; Mon, 14 Sep 2026 22:15:56 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 6ExvxJcMQY4rX6ExvxOuiU; Mon, 14 Sep 2026 22:15:55 +0000 X-Authority-Analysis: v=2.4 cv=CI8qXQrD c=1 sm=1 tr=0 ts=6aa8721b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=VdqzKS8jKosA:10 a=ItBw4LHWJt0A:10 a=uDMyNUl5K7NUpY0i5owA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nVZE59trOtwyzzfEiEE8EhSH1CeMi0px2nFKa6fizEk=; b=IGjd7Vmi8HzKZyGKryxUtGKdkX dTM7BrJWL+kO1PVXvvn2kjkO03gSDmGrgA6+BUYjf3O0etqlh7iw8FQzcAOuOp5+uoZ7qq2smkF8C C7GIu4/ERICQ9B+mUlISmcnAa; Received: from 75-166-229-74.hlrn.qwest.net ([75.166.229.74]:42584 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100) (envelope-from ) id 1x6Exu-00000003Ig9-31uo; Mon, 14 Sep 2026 16:15:54 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Wrap (and poison) PyObject_CallFunctionObjArgs In-Reply-To: <7288831a-098e-486d-8c02-088a2e1affc3@simark.ca> (Simon Marchi's message of "Mon, 14 Sep 2026 16:09:20 -0400") References: <20260914190624.4178522-1-tom@tromey.com> <7288831a-098e-486d-8c02-088a2e1affc3@simark.ca> X-Attribution: Tom Date: Mon, 14 Sep 2026 16:15:53 -0600 Message-ID: <87pkyf5vja.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.229.74 X-Source-L: No X-Exim-ID: 1x6Exu-00000003Ig9-31uo X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-229-74.hlrn.qwest.net (prentzel) [75.166.229.74]:42584 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfEJLyWkHUw9k/ZrwFW8TSONKy6bw1RwgRPdvuMg5hpvW47bOg46P5k89r4x1HalKxb/eQrXvkBZYrKhM6QSPSyrhcKlsOCZYwcz88YLAZETL/lQq838C cBlmNPl6fH/LV1SGSgq9kcEnEFKfI5s3g5OBTLQ95TFHCPkQdSz9MG0WAwRScdpP+pImpjBzF2g4fyv64V3GBjxID4BTaOyNorg= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >> +/* Poison PyObject_CallFunctionObjArgs. The typesafe wrapper >> + gdbpy_objects_call_function_obj_args should be used instead. */ Simon> Typo, gdbpy_objects_call_function_obj_ar -> gdbpy_object_call_function_obj_args I fixed it. >> +#undef PyObject_CallFunctionObjArgs >> +#ifdef __GNUC__ >> +# pragma GCC poison PyObject_CallFunctionObjArgs >> +#else >> +# define PyObject_CallFunctionObjArgs POISONED_PyObject_CallFunctionObjArgs >> +#endif Simon> Clang appears to support "pragma GCC poison", could we use it Simon> unconditionnaly? I don't know. I just copied similar code from elsewhere in the file. Tom