From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [7/10] keep track of dependencies
Date: Thu, 10 May 2012 15:50:00 -0000 [thread overview]
Message-ID: <87obpwox1y.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20120426202743.GA23244@host2.jankratochvil.net> (Jan Kratochvil's message of "Thu, 26 Apr 2012 22:27:43 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
I made most of the changes you pointed out in this review.
Thanks.
[...]
Jan> Why is RESULT_CHILDREN used here at all? Would not it be
Jan> sufficient to just call htab_traverse for ALL_CHILDREN?
Maybe it isn't a great reason, but it lets us easily avoid adding CUs
without symbol tables. See recursively_compute_inclusions:
if (get_symtab (per_cu) != NULL)
VEC_safe_push (dwarf2_per_cu_ptr, *result, per_cu);
So, RESULT_CHILDREN and ALL_CHILDREN do not have identical contents.
Tom
next prev parent reply other threads:[~2012-05-10 15:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 18:56 Tom Tromey
2012-04-26 20:33 ` Jan Kratochvil
2012-05-10 15:50 ` Tom Tromey [this message]
2012-05-11 14:41 ` Jan Kratochvil
2012-05-10 20:13 ` Tom Tromey
2012-05-10 20:14 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obpwox1y.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox