From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4314 invoked by alias); 10 May 2012 15:50:29 -0000 Received: (qmail 4306 invoked by uid 22791); 10 May 2012 15:50:29 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 May 2012 15:50:04 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4AFo3vH025915 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 10 May 2012 11:50:03 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4AFo2w7032498 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 10 May 2012 11:50:02 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [7/10] keep track of dependencies References: <87zk9zabho.fsf@fleche.redhat.com> <20120426202743.GA23244@host2.jankratochvil.net> Date: Thu, 10 May 2012 15:50:00 -0000 In-Reply-To: <20120426202743.GA23244@host2.jankratochvil.net> (Jan Kratochvil's message of "Thu, 26 Apr 2012 22:27:43 +0200") Message-ID: <87obpwox1y.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00367.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: I made most of the changes you pointed out in this review. Thanks. [...] Jan> Why is RESULT_CHILDREN used here at all? Would not it be Jan> sufficient to just call htab_traverse for ALL_CHILDREN? Maybe it isn't a great reason, but it lets us easily avoid adding CUs without symbol tables. See recursively_compute_inclusions: if (get_symtab (per_cu) != NULL) VEC_safe_push (dwarf2_per_cu_ptr, *result, per_cu); So, RESULT_CHILDREN and ALL_CHILDREN do not have identical contents. Tom