From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [downstream patch FYI] workaround stale frame_info * (PR 13866)
Date: Fri, 18 May 2012 17:44:00 -0000 [thread overview]
Message-ID: <87obplgz9q.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20120404191416.GA29603@host2.jankratochvil.net> (Jan Kratochvil's message of "Wed, 4 Apr 2012 21:14:16 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> With proper C++ sanity check of stale live frame_info references
Jan> the testcase would be simple without the "frame_garbage_collection"
Jan> reproducer below. It is also reproducible just with valgrind but
Jan> regularly running the whole testsuite under valgrind I did not find
Jan> feasible.
I was thinking about this problem recently.
One idea would be to only let unwinders access struct frame_info, and
have all other code use struct frame_id, perhaps with some simple cache
so that repeated calls for a given frame_id will not cause too much
work.
This would make it much harder to cache information when not allowed.
On the minus side, there are 1300 uses of struct frame_info to audit.
Tom
next prev parent reply other threads:[~2012-05-18 17:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 19:14 Jan Kratochvil
2012-05-18 17:44 ` Tom Tromey [this message]
2012-05-18 18:01 ` Pedro Alves
2012-05-18 18:04 ` Jan Kratochvil
2012-05-18 19:16 ` Tom Tromey
2012-06-05 19:17 ` Pedro Alves
2012-06-05 19:39 ` Jan Kratochvil
2012-06-05 19:41 ` Pedro Alves
2012-06-05 19:50 ` Pedro Alves
2012-06-06 19:38 ` Tom Tromey
2012-06-06 20:16 ` Pedro Alves
2012-06-05 19:24 ` Pedro Alves
2012-06-05 19:52 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obplgz9q.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox