From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [downstream patch FYI] workaround stale frame_info * (PR 13866)
Date: Wed, 06 Jun 2012 19:38:00 -0000 [thread overview]
Message-ID: <87d35cgrik.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20120605193920.GA19998@host2.jankratochvil.net> (Jan Kratochvil's message of "Tue, 5 Jun 2012 21:39:20 +0200")
Pedro> I've then ran the whole testsuite with this on, and that didn't catch
Pedro> any other problem. You mention in PR13866 many situations with stale
Pedro> frame_info; did you have some other way to catch those,
Jan> No. This single PR13866 crash and GDB code in general gives me enough
Jan> reasoning to believe:
Jan> (a) There exist other such crashes in GDB, just not tested by the
Jan> testsuite.
Jan> (b) More of such crashes will regress by changes in the future.
Jan> This is just my personal opinion you may not agree with.
Despite the difficulties perhaps we should try to write a static
analyzer for this. I am not sure if it could be made reliable enough,
but maybe it could. The problem cases are when the analyzer must
account for cleanups -- but in this case we might be able to get away
with ignoring them.
Another idea is to simply get rid of frame_info and have only a
frame_id-based API.
Tom
next prev parent reply other threads:[~2012-06-06 19:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 19:14 Jan Kratochvil
2012-05-18 17:44 ` Tom Tromey
2012-05-18 18:01 ` Pedro Alves
2012-05-18 18:04 ` Jan Kratochvil
2012-05-18 19:16 ` Tom Tromey
2012-06-05 19:17 ` Pedro Alves
2012-06-05 19:39 ` Jan Kratochvil
2012-06-05 19:41 ` Pedro Alves
2012-06-05 19:50 ` Pedro Alves
2012-06-06 19:38 ` Tom Tromey [this message]
2012-06-06 20:16 ` Pedro Alves
2012-06-05 19:24 ` Pedro Alves
2012-06-05 19:52 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d35cgrik.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox