From: Tom Tromey <tromey@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: "gp \>\> \"gdb-patches\@sourceware.org ml\""
<gdb-patches@sourceware.org>
Subject: Re: [RFA] Cleanup: Use add_sal_to_sals for expressions
Date: Wed, 18 Jul 2012 20:11:00 -0000 [thread overview]
Message-ID: <87obnc25jq.fsf@fleche.redhat.com> (raw)
In-Reply-To: <50070B0D.2050002@redhat.com> (Keith Seitz's message of "Wed, 18 Jul 2012 12:14:21 -0700")
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> As much as I hate to extend the API for add_sal_to_sals (especially
Keith> for a special case like this), but I really want [to try?] to isolate
Keith> name canonicalization in one place, and add_sal_to_sals seems like the
Keith> best candidate for that.
Seems reasonable to me.
Keith> So, what do you think of this revised patch? [No regressions on x86-64
Keith> linux.]
Ok.
Tom
next prev parent reply other threads:[~2012-07-18 20:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 21:29 Keith Seitz
2012-07-18 16:35 ` Tom Tromey
2012-07-18 19:14 ` Keith Seitz
2012-07-18 20:11 ` Tom Tromey [this message]
2012-07-18 20:40 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obnc25jq.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox