From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-92845-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3172 invoked by alias); 18 Jul 2012 20:11:46 -0000
Received: (qmail 3162 invoked by uid 22791); 18 Jul 2012 20:11:45 -0000
X-SWARE-Spam-Status: No, hits=-6.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Jul 2012 20:11:23 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6IKBMa9002183	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Wed, 18 Jul 2012 16:11:22 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q6IKBLEh024658	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 18 Jul 2012 16:11:22 -0400
From: Tom Tromey <tromey@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: "gp \>\> \"gdb-patches\@sourceware.org ml\"" <gdb-patches@sourceware.org>
Subject: Re: [RFA] Cleanup: Use add_sal_to_sals for expressions
References: <5005D93D.7020808@redhat.com> <878veh3u4z.fsf@fleche.redhat.com>	<50070B0D.2050002@redhat.com>
Date: Wed, 18 Jul 2012 20:11:00 -0000
In-Reply-To: <50070B0D.2050002@redhat.com> (Keith Seitz's message of "Wed, 18	Jul 2012 12:14:21 -0700")
Message-ID: <87obnc25jq.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-07/txt/msg00301.txt.bz2

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> As much as I hate to extend the API for add_sal_to_sals (especially
Keith> for a special case like this), but I really want [to try?] to isolate
Keith> name canonicalization in one place, and add_sal_to_sals seems like the
Keith> best candidate for that.

Seems reasonable to me.

Keith> So, what do you think of this revised patch? [No regressions on x86-64
Keith> linux.]

Ok.

Tom