From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Keith Seitz <keiths@redhat.com>,
"gdb-patches\@sourceware.org ml"
<gdb-patches@sourceware.org>
Subject: Re: [RFA] Fix two memory leaks
Date: Wed, 24 Oct 2012 14:55:00 -0000 [thread overview]
Message-ID: <87objrapj0.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20121023220236.GG3555@adacore.com> (Joel Brobecker's message of "Tue, 23 Oct 2012 18:02:36 -0400")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> This one looks good to me. But I'm wonderin if we shouldn't also
Joel> document the fact that decode_line_with_current_source returns
Joel> a structure that contains newly allocated memory?
The docs for it should probably reference decode_line_full.
>> * linespec.c (parse_linespec): Do cleanups after
>> parsing a convenience variable.
Joel> This one looks good to me too.
Joel> You might want to wait for a day or two before checking in, as these
Joel> files are not within my area of expertise. But I verified that the
Joel> memory is allocated on the heap, and leaked if not free'ed.
I think they are both ok as well.
Tom
prev parent reply other threads:[~2012-10-24 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 21:22 Keith Seitz
2012-10-23 22:02 ` Joel Brobecker
2012-10-24 14:55 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87objrapj0.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox