From: Joel Brobecker <brobecker@adacore.com>
To: Keith Seitz <keiths@redhat.com>
Cc: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA] Fix two memory leaks
Date: Tue, 23 Oct 2012 22:02:00 -0000 [thread overview]
Message-ID: <20121023220236.GG3555@adacore.com> (raw)
In-Reply-To: <50870A74.80903@redhat.com>
Hi Keith,
Tsk, tsk, tsk - can we have two separate patches, please? :-)
Seriously, it does make it easier if we have unexpected regressions...
> ChangeLog
> 2012-10-23 Keith Seitz <keiths@redhat.com>
>
> * breakpoint.c (clear_command): Add cleanup for
> sals.sals if an argument is given.
This one looks good to me. But I'm wonderin if we shouldn't also
document the fact that decode_line_with_current_source returns
a structure that contains newly allocated memory?
> * linespec.c (parse_linespec): Do cleanups after
> parsing a convenience variable.
This one looks good to me too.
You might want to wait for a day or two before checking in, as these
files are not within my area of expertise. But I verified that the
memory is allocated on the heap, and leaked if not free'ed.
Cheers,
--
Joel
next prev parent reply other threads:[~2012-10-23 22:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 21:22 Keith Seitz
2012-10-23 22:02 ` Joel Brobecker [this message]
2012-10-24 14:55 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121023220236.GG3555@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox