Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/2] Move registering maint commands from maint.c to psymtalb.c
Date: Wed, 19 Dec 2012 14:23:00 -0000	[thread overview]
Message-ID: <87obhqp1dl.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1355903736-25543-1-git-send-email-yao@codesourcery.com> (Yao	Qi's message of "Wed, 19 Dec 2012 15:55:35 +0800")

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> I don't see the reason we have to register 'maint commands' inside
Yao> maint.c.  This patch moves code registering commands out of maint.c so
Yao> that the command functions can be 'static'.

Thanks.

Yao> +void _initialize_psymtab (void);

I've been writing

initialize_file_ftype _initialize_psymtab;

in similar cases.

Tom


      parent reply	other threads:[~2012-12-19 14:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-19  7:56 Yao Qi
2012-12-19  7:56 ` [PATCH 2/2] Move registering maint cmd from maint.c to symmisc.c Yao Qi
2012-12-19 14:23   ` Tom Tromey
2012-12-20  1:12     ` [committed] : " Yao Qi
2012-12-19 14:23 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87obhqp1dl.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox