From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-97227-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1110 invoked by alias); 19 Dec 2012 14:23:14 -0000
Received: (qmail 1100 invoked by uid 22791); 19 Dec 2012 14:23:13 -0000
X-SWARE-Spam-Status: No, hits=-6.4 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 19 Dec 2012 14:23:07 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBJEN3rQ025042	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 19 Dec 2012 09:23:04 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBJEN2kH020407	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 19 Dec 2012 09:23:03 -0500
From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/2] Move registering maint commands from maint.c to psymtalb.c
References: <1355903736-25543-1-git-send-email-yao@codesourcery.com>
Date: Wed, 19 Dec 2012 14:23:00 -0000
In-Reply-To: <1355903736-25543-1-git-send-email-yao@codesourcery.com> (Yao	Qi's message of "Wed, 19 Dec 2012 15:55:35 +0800")
Message-ID: <87obhqp1dl.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-12/txt/msg00700.txt.bz2

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> I don't see the reason we have to register 'maint commands' inside
Yao> maint.c.  This patch moves code registering commands out of maint.c so
Yao> that the command functions can be 'static'.

Thanks.

Yao> +void _initialize_psymtab (void);

I've been writing

initialize_file_ftype _initialize_psymtab;

in similar cases.

Tom