Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: RFC: fix PR gdb/15538
Date: Tue, 16 Apr 2013 05:54:00 -0000	[thread overview]
Message-ID: <87obdfbn8n.fsf@fleche.redhat.com> (raw)

This fixes PR 15538, an assertion failure when reading a certain file.

The bug is that dwarf2_record_block_ranges asserts that the ranges
section has been read in -- but it can be called without this occurring.

The fix is to simply read in the section in dwarf2_record_block_ranges.

I didn't know how to make a test case, so I haven't provided one.
If this is an issue I will try harder to figure it out.

Built and regtested on x86-64 Fedora 18.
The bug reporter also tested it.

Tom

    	PR gdb/15538:
    	* dwarf2read.c (dwarf2_record_block_ranges): Ensure that the
    	ranges section has been read.

diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index 8947f8f..64fc7da 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -10458,7 +10458,7 @@ dwarf2_record_block_ranges (struct die_info *die, struct block *block,
          address range list in the .debug_ranges section.  */
       unsigned long offset = (DW_UNSND (attr)
 			      + (need_ranges_base ? cu->ranges_base : 0));
-      const gdb_byte *buffer = dwarf2_per_objfile->ranges.buffer + offset;
+      const gdb_byte *buffer;
 
       /* For some target architectures, but not others, the
          read_address function sign-extends the addresses it returns.
@@ -10477,7 +10477,7 @@ dwarf2_record_block_ranges (struct die_info *die, struct block *block,
       CORE_ADDR base = cu->base_address;
       int base_known = cu->base_known;
 
-      gdb_assert (dwarf2_per_objfile->ranges.readin);
+      dwarf2_read_section (objfile, &dwarf2_per_objfile->ranges);
       if (offset >= dwarf2_per_objfile->ranges.size)
         {
           complaint (&symfile_complaints,
@@ -10485,6 +10485,7 @@ dwarf2_record_block_ranges (struct die_info *die, struct block *block,
                      offset);
           return;
         }
+      buffer = dwarf2_per_objfile->ranges.buffer + offset;
 
       for (;;)
         {


             reply	other threads:[~2013-04-15 19:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-16  5:54 Tom Tromey [this message]
2013-04-16  7:52 ` Pedro Alves
2013-04-16  7:52   ` Tom Tromey
2013-04-16 15:45     ` Tom Tromey
2013-05-13 16:54 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87obdfbn8n.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox