From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1869 invoked by alias); 15 Apr 2013 19:36:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1855 invoked by uid 89); 15 Apr 2013 19:36:01 -0000 X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 15 Apr 2013 19:35:55 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3FJZraf011401 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 15 Apr 2013 15:35:54 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r3FJZqc6003176 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 15 Apr 2013 15:35:53 -0400 From: Tom Tromey To: gdb-patches@sourceware.org Subject: RFC: fix PR gdb/15538 Date: Tue, 16 Apr 2013 05:54:00 -0000 Message-ID: <87obdfbn8n.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-04/txt/msg00444.txt.bz2 This fixes PR 15538, an assertion failure when reading a certain file. The bug is that dwarf2_record_block_ranges asserts that the ranges section has been read in -- but it can be called without this occurring. The fix is to simply read in the section in dwarf2_record_block_ranges. I didn't know how to make a test case, so I haven't provided one. If this is an issue I will try harder to figure it out. Built and regtested on x86-64 Fedora 18. The bug reporter also tested it. Tom PR gdb/15538: * dwarf2read.c (dwarf2_record_block_ranges): Ensure that the ranges section has been read. diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index 8947f8f..64fc7da 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -10458,7 +10458,7 @@ dwarf2_record_block_ranges (struct die_info *die, struct block *block, address range list in the .debug_ranges section. */ unsigned long offset = (DW_UNSND (attr) + (need_ranges_base ? cu->ranges_base : 0)); - const gdb_byte *buffer = dwarf2_per_objfile->ranges.buffer + offset; + const gdb_byte *buffer; /* For some target architectures, but not others, the read_address function sign-extends the addresses it returns. @@ -10477,7 +10477,7 @@ dwarf2_record_block_ranges (struct die_info *die, struct block *block, CORE_ADDR base = cu->base_address; int base_known = cu->base_known; - gdb_assert (dwarf2_per_objfile->ranges.readin); + dwarf2_read_section (objfile, &dwarf2_per_objfile->ranges); if (offset >= dwarf2_per_objfile->ranges.size) { complaint (&symfile_complaints, @@ -10485,6 +10485,7 @@ dwarf2_record_block_ranges (struct die_info *die, struct block *block, offset); return; } + buffer = dwarf2_per_objfile->ranges.buffer + offset; for (;;) {