Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Cc: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH V2] PR varobj/18564  regression in showing __thread so extern variable
Date: Thu, 10 Sep 2015 20:14:00 -0000	[thread overview]
Message-ID: <87oahakp51.fsf@redhat.com> (raw)
In-Reply-To: <1441317832.4429.4.camel@skynet.be> (Philippe Waroquiers's	message of "Fri, 04 Sep 2015 00:03:52 +0200")

On Thursday, September 03 2015, Philippe Waroquiers wrote:

> On Thu, 2015-09-03 at 10:37 +0100, Yao Qi wrote:
>> We don't have to get printf involved in the test, because some targets
>> may don't have printf at all.
> Ok, effectively, without printf, the test will then run on these
> targets.
>
> Find below the new version of the patch.
> All your comments should be handled.
>
> The fix itself still need to be reviewed.
>
> Thanks for your review
>
> Any comment on the fix ? Ok to commit ?

Thanks, Philippe.

I wanted to reply to this earlier, sorry.  I looked at your proposed
patch, and it looks fine for me.  It makes sense, and is "simple" enough
that nothing seemed out of place.

I am not a maintainer for this part of the code, but I think it can be
safely approved.

Thanks again,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


  parent reply	other threads:[~2015-09-10 20:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-30 11:34 [PATCH] " Philippe Waroquiers
2015-09-02 13:03 ` Yao Qi
2015-09-02 21:23   ` Philippe Waroquiers
2015-09-03  9:37     ` Yao Qi
2015-09-03 22:03       ` [PATCH V2] " Philippe Waroquiers
2015-09-10 14:34         ` Pedro Alves
2015-09-15 19:15           ` Philippe Waroquiers
2015-09-10 20:14         ` Sergio Durigan Junior [this message]
2015-09-10 20:17           ` Sergio Durigan Junior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oahakp51.fsf@redhat.com \
    --to=sergiodj@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=philippe.waroquiers@skynet.be \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox