From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128880 invoked by alias); 10 Sep 2015 20:14:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128838 invoked by uid 89); 10 Sep 2015 20:14:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 10 Sep 2015 20:14:53 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 80AE2AACCA; Thu, 10 Sep 2015 20:14:51 +0000 (UTC) Received: from localhost (unused-10-15-17-51.yyz.redhat.com [10.15.17.51]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8AKEo81025407 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 10 Sep 2015 16:14:51 -0400 From: Sergio Durigan Junior To: Philippe Waroquiers Cc: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH V2] PR varobj/18564 regression in showing __thread so extern variable References: <1440934487.22248.9.camel@skynet.be> <86wpw9x9au.fsf@gmail.com> <1441229015.13071.23.camel@skynet.be> <86h9nbyhb6.fsf@gmail.com> <1441317832.4429.4.camel@skynet.be> X-URL: http://blog.sergiodj.net Date: Thu, 10 Sep 2015 20:14:00 -0000 In-Reply-To: <1441317832.4429.4.camel@skynet.be> (Philippe Waroquiers's message of "Fri, 04 Sep 2015 00:03:52 +0200") Message-ID: <87oahakp51.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00181.txt.bz2 On Thursday, September 03 2015, Philippe Waroquiers wrote: > On Thu, 2015-09-03 at 10:37 +0100, Yao Qi wrote: >> We don't have to get printf involved in the test, because some targets >> may don't have printf at all. > Ok, effectively, without printf, the test will then run on these > targets. > > Find below the new version of the patch. > All your comments should be handled. > > The fix itself still need to be reviewed. > > Thanks for your review > > Any comment on the fix ? Ok to commit ? Thanks, Philippe. I wanted to reply to this earlier, sorry. I looked at your proposed patch, and it looks fine for me. It makes sense, and is "simple" enough that nothing seemed out of place. I am not a maintainer for this part of the code, but I think it can be safely approved. Thanks again, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/